Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove postemsasgeiframe listener on close #228

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

shanejonas
Copy link
Member

No description provided.

@shanejonas shanejonas self-assigned this Dec 7, 2020
@shanejonas shanejonas added the bug Something isn't working label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #228 (907dd0d) into master (9abb044) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #228   +/-   ##
=======================================
  Coverage   98.96%   98.97%           
=======================================
  Files          11       11           
  Lines         387      389    +2     
  Branches       53       60    +7     
=======================================
+ Hits          383      385    +2     
  Misses          4        4           
Impacted Files Coverage Δ
src/transports/PostMessageIframeTransport.ts 97.50% <83.33%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abb044...907dd0d. Read the comment docs.

@shanejonas shanejonas merged commit 1365882 into master Dec 7, 2020
@shanejonas shanejonas deleted the fix/remove-event-listener-close branch December 7, 2020 19:21
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants