Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/by name still banged up #360

Merged
merged 4 commits into from
May 6, 2020
Merged

Fix/by name still banged up #360

merged 4 commits into from
May 6, 2020

Conversation

BelfordZ
Copy link
Member

@BelfordZ BelfordZ commented May 6, 2020

Sets the paramStructure default to be Either (depends on open-rpc/spec#270)

depends on open-rpc/meta-schema#217

@BelfordZ BelfordZ requested a review from shanejonas May 6, 2020 00:07
@BelfordZ BelfordZ self-assigned this May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          162       171    +9     
  Branches        33        35    +2     
=========================================
+ Hits           162       171    +9     
Impacted Files Coverage Δ
src/generate-method-id.ts 100.00% <100.00%> (ø)
src/method-call-validator/method-call-validator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7251f8...8c161bb. Read the comment docs.

@BelfordZ BelfordZ added the bug Something isn't working label May 6, 2020
@BelfordZ BelfordZ added this to In progress in OpenRPC via automation May 6, 2020
OpenRPC automation moved this from In progress to Reviewer approved May 6, 2020
@BelfordZ BelfordZ merged commit 3d50413 into master May 6, 2020
OpenRPC automation moved this from Reviewer approved to Done May 6, 2020
@BelfordZ BelfordZ deleted the fix/by-name-still-banged-up branch May 6, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
OpenRPC
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants