Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paramStructure should default to "either" #270

Closed
shanejonas opened this issue Apr 18, 2020 · 1 comment · Fixed by #273
Closed

paramStructure should default to "either" #270

shanejonas opened this issue Apr 18, 2020 · 1 comment · Fixed by #273
Labels
triage

Comments

@shanejonas
Copy link
Member

Having it default to by-position right now I think is confusing, the spec says either is allowed so I think it should be the default.

rel: #190 (comment)
@BelfordZ BelfordZ mentioned this issue Apr 27, 2020
Closed
BelfordZ added a commit that referenced this issue Apr 27, 2020
@BelfordZ
fix: default paramStructure to either
558241f 
fixes #270
@BelfordZ BelfordZ mentioned this issue Apr 27, 2020
Merged
This was referenced May 6, 2020
Merged
Merged
openrpc-bastion added a commit that referenced this issue May 6, 2020
@openrpc-bastion
chore(release): 1.2.5 [skip ci]
4ae81de 
## [1.2.5](1.2.4...1.2.5) (2020-05-06)

### Bug Fixes

* default paramStructure to either ([558241f](558241f)), closes [#270](#270)
@BelfordZ
Copy link
Member

release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: default paramStructure to either open-rpc/spec
2 participants
@shanejonas @BelfordZ