Feature: Force login when checking the box

[bdougie]

Type of feature

🍕 Feature

Current behavior

Today when a user is logged out, we do not allow them to check a box. Instead we make this an allowed action. When the user clicks "Create Insight," that should logged them in and present them with an insight page with the items selected in the cart.

Suggested solution

Additional context

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[a0m0rajab]

This is challenging, but I would like to work on it. If it's not urgent, I will work on the weekend.
.take

[github-actions]

The auto-take issues workflow is not enabled here, we can only assign issues to @open-sauced/triage, @open-sauced/committers, @open-sauced/maintainers in this repo for now. We suggest folks not on the team open issues and take a look at the Bugs or Papercuts. If you would like to find good first issues, please check out the companion project to this, open-sauced/hot.

[a0m0rajab]

As first insights:

The login can be done with the Supabase auth: https://github.com/open-sauced/insights/blob/beta/pages/hub/insights/%5BinsightId%5D/accept.tsx#L16

The selected repo is being handled in the repo table:
https://github.com/open-sauced/insights/blob/beta/components/organisms/RepositoriesTable/repositories-table.tsx

The check box is disabled in the table row:
https://github.com/open-sauced/insights/blob/beta/components/molecules/RepoRow/repo-row.tsx#L211

What's the next step:

• we should enable the checkbox in the table row.
• Add the login logic to the add to insight page button based on the connect one (from the first link)

[a0m0rajab]

I could not open the list of the repos

I got this issue:

is it related to the .env file or something else? @takanome-dev

[takanome-dev]

I'm not really sure, I'm getting the same error right now.

The response status is 524

What Is the 524 Gateway Timeout Error? The 524 gateway Timeout Error is a Cloudflare-specific HTTP status code that indicates that the connection to the server has been closed due to a timeout.

Maybe it's due to slow network 🤔

cc @0-vortex @OgDev-01 any ideas?

[OgDev-01]

@takanome-dev and @a0m0rajab
Auth in beta is currently down and will be fixed soonest. That is the reason you get the error 524

[a0m0rajab]

Thank you for the information and help.

[a0m0rajab]

@OgDev-01 @0-vortex just thought, if the fix could take time, is there any dummy data been used before for such a situation?

[bdougie]

@a0m0rajab beta is fixed.

[a0m0rajab]

Opened a PR. There are two things I noticed here I am not sure if I should do in this PR or create a new one:

1. The redirect option in the sign-in logic is not redirecting to the same page, it's going to the main page: https://github.com/open-sauced/insights/blob/beta/lib/hooks/useSupabaseAuth.ts#L43
2. The logic we have right now does not keep track of the selected repos. It's just forcing sign-in, should we keep track of the repos and use that when we force the user to sign in?

From my perspective, I think both of them need to be done, but wanted to get your input.

[bdougie]

Both are needed in this PR. I don't know @brandonroberts has a better suggestion but I think we could use the context library to save that while being redirected.

[brandonroberts]

1. The redirect URL after login is something we still need to handle. I think we solved the issue with the config, but need to verify.
2. If we force login as soon as they try to check one of the boxes, tracking the repos isn't going to help much there. If we let them check the repositories, and force login when they click to create a page, then we could store them in the redirect URL for when they come back after login. This is what we do currently if they are already logged in

[takanome-dev]

I think there is an open issue about the redirect after login here -> #1075

[a0m0rajab]

@takanome-dev Thank you for that! it helped me!

I added redirect in the last commit that I have but there is only one issue, when I add the query data to the redirect it's just not being sent to the redirect.

[github-actions]

🎉 This issue has been resolved in version 1.54.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 1.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀