feat: force login (close #1132) #1184

a0m0rajab · 2023-05-16T13:41:10Z

What type of PR is this? (check all applicable)

Description

This PR closes #1132

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

When the user is not logged it, it will force login.

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

netlify · 2023-05-16T13:41:18Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`f7cd091`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/6499b5078495840008424b8c
😎 Deploy Preview	https://deploy-preview-1184--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-05-16T13:41:22Z

✅ Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`f7cd091`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/6499b507d0b465000844e32a
😎 Deploy Preview	https://deploy-preview-1184--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brandonroberts · 2023-05-17T17:54:31Z

We can land this but if they select repos and are go to login, when they return the repos won't be selected

components/organisms/Repositories/repositories.tsx

a0m0rajab · 2023-05-22T18:10:11Z

Is there any updates I need to do for this PR?

brandonroberts · 2023-05-23T15:46:26Z

@a0m0rajab does this redirect to the new insight page with the selected repos after login?

a0m0rajab · 2023-05-23T21:17:52Z

No, I just misunderstood your first comment, wanted to know what you meant by refactoring.
I think it means something to serialize selectedRepos and send it within the URL, I will work on that.

a0m0rajab · 2023-05-30T12:21:28Z

I think going with url?param=value approach is kinda not feasible, I tried to do that and passing the selected repos but it got me into this issue, it might require something different to do there.

The supabase redirect functioned worked one time while doing this not sure how...

As a solution to have shorter URL would be to pass an array with repos IDs and parse them in the app.

Beside that one thing I figured was that: the router.query condition is running multiple times in the insights page.

brandonroberts · 2023-05-30T15:42:24Z

@a0m0rajab yes, only passing selectRepos as just the IDs would be a better fix. Then you'd have to fetch the repos using the selectedRepos in the InsightPage.tsx component and add them to the listed repos.

a0m0rajab · 2023-05-30T18:27:05Z

Thank you for that, Just another solution I got in mind is using localStorage to get the repos as well.
If the query params did not work, I might work on this one.

brandonroberts · 2023-05-30T19:06:27Z

We discussed using local storage previously and its too prone to error with unpredictable navigation

OgDev-01 · 2023-06-02T06:45:48Z

Hey @a0m0rajab, have you been able to try @brandonroberts suggestion?... Let me know if you are blocked anytime 👍

a0m0rajab · 2023-06-02T08:56:47Z

@OgDev-01 Thank you for asking, I just did not find time recently, might do it at the weekend.
@brandonroberts Thank you for letting me know, I will go with passing IDs and see how things will work.

a0m0rajab · 2023-06-05T14:43:03Z

Got blocked while working on this, had the same long URI issue from supabase this time.
I feel either going with localstorage would solve this, what errors have you faced while doing such approach? (I used local storage previously without getting any issues)

takanome-dev · 2023-06-06T19:26:05Z

Hey @a0m0rajab, the Supabase redirect issue was fixed in #1240. Try pulling the latest changes and try it again. Let us know if you're still facing an issue 🍕

…nto force-login

a0m0rajab · 2023-06-08T21:28:38Z

@takanome-dev it did not work, still the same issue,

I think it was my mistake, just solved the issue, had to remove a test code.

a0m0rajab · 2023-06-21T21:22:03Z

@brandonroberts is this what you are talking about?
I think it's an expected behavior:

2023-06-22.00-18-04.mp4

Or do you mean that if they logged out in the add new insight page, we need to stay at the same page?

brandonroberts · 2023-06-22T02:08:20Z

@a0m0rajab I was logged out, I selected some repos, and clicked "Add to Insight Page". It took me to login, and brought me back but didn't keep me on the "Create Insight Page" with the selected repos

a0m0rajab · 2023-06-22T14:19:51Z

@brandonroberts could it be a cache issue? I tried this with incognito mode and it worked.

2023-06-22.17-16-05.mp4

brandonroberts · 2023-06-22T18:30:21Z

@a0m0rajab I haven't tried it locally, but only through the PR deploy preview. I tried it with incognito mode also

a0m0rajab · 2023-06-22T18:59:13Z

I will add a few debuggers to test the issue.

This reverts commit f672c1d.

a0m0rajab · 2023-06-22T20:38:55Z

@brandonroberts i tested it on the preview and it worked, I had to change the remove login to signout.

a0m0rajab · 2023-06-23T08:25:15Z

Latest video:

2023-06-23.11-23-58.mp4

brandonroberts

Minor tweak

layouts/private-wrapper.tsx

brandonroberts · 2023-06-26T14:04:21Z

@a0m0rajab everything works correctly now. Remove the console.log statements and we're good to go

a0m0rajab · 2023-06-26T15:56:08Z

Done 👍

## [1.54.0-beta.4](v1.54.0-beta.3...v1.54.0-beta.4) (2023-06-26) ### 🍕 Features * allow login flow after selecting repositories to add to insight page (close [#1132](#1132)) ([#1184](#1184)) ([21aaa0b](21aaa0b))

github-actions · 2023-06-26T20:31:43Z

🎉 This PR is included in version 1.54.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.54.0](v1.53.0...v1.54.0) (2023-06-28) ### 🐛 Bug Fixes * fix yellow color for `<Pill />` component ([#1299](#1299)) ([2f2d9f5](2f2d9f5)) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](#1304)) ([976739f](976739f)) * add `BillBoard` component to design system ([#1306](#1306)) ([1181cfd](1181cfd)) * add `FeaturedHighlightPanel` component to design system ([#1307](#1307)) ([452213c](452213c)) * add `UserCard` component to storybook design system ([#1295](#1295)) ([6867011](6867011)) * add highlight prompt to design system ([#1297](#1297)) ([4a85e74](4a85e74)) * add top users panel component to design system ([#1300](#1300)) ([9c05fec](9c05fec)) * add URL for collaboration requests ([#1305](#1305)) ([b3f8ea5](b3f8ea5)) * allow login flow after selecting repositories to add to insight page (close [#1132](#1132)) ([#1184](#1184)) ([21aaa0b](21aaa0b)) * implemented/added scroll-area component to design-system ([#1283](#1283)) ([b7280ab](b7280ab))

github-actions · 2023-06-28T17:56:30Z

🎉 This PR is included in version 1.54.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.54.0-beta.4](open-sauced/app@v1.54.0-beta.3...v1.54.0-beta.4) (2023-06-26) ### 🍕 Features * allow login flow after selecting repositories to add to insight page (close [#1132](open-sauced/app#1132)) ([#1184](open-sauced/app#1184)) ([21aaa0b](open-sauced/app@21aaa0b))

## [1.54.0](open-sauced/app@v1.53.0...v1.54.0) (2023-06-28) ### 🐛 Bug Fixes * fix yellow color for `<Pill />` component ([#1299](open-sauced/app#1299)) ([2f2d9f5](open-sauced/app@2f2d9f5)) ### 🍕 Features * hide highlights tab components on profiles without highlights ([#1304](open-sauced/app#1304)) ([976739f](open-sauced/app@976739f)) * add `BillBoard` component to design system ([#1306](open-sauced/app#1306)) ([1181cfd](open-sauced/app@1181cfd)) * add `FeaturedHighlightPanel` component to design system ([#1307](open-sauced/app#1307)) ([452213c](open-sauced/app@452213c)) * add `UserCard` component to storybook design system ([#1295](open-sauced/app#1295)) ([6867011](open-sauced/app@6867011)) * add highlight prompt to design system ([#1297](open-sauced/app#1297)) ([4a85e74](open-sauced/app@4a85e74)) * add top users panel component to design system ([#1300](open-sauced/app#1300)) ([9c05fec](open-sauced/app@9c05fec)) * add URL for collaboration requests ([#1305](open-sauced/app#1305)) ([b3f8ea5](open-sauced/app@b3f8ea5)) * allow login flow after selecting repositories to add to insight page (close [#1132](open-sauced/app#1132)) ([#1184](open-sauced/app#1184)) ([21aaa0b](open-sauced/app@21aaa0b)) * implemented/added scroll-area component to design-system ([#1283](open-sauced/app#1283)) ([b7280ab](open-sauced/app@b7280ab))

feat: force login (close open-sauced#1132)

0dfb144

brandonroberts requested review from bdougie and OgDev-01 May 17, 2023 17:54

chore: add redirect

ff2f351

a0m0rajab commented May 17, 2023

View reviewed changes

components/organisms/Repositories/repositories.tsx Outdated Show resolved Hide resolved

Merge branch 'beta' into force-login

54f4ee3

Merge branch 'beta' into force-login

2708d55

Merge branch 'beta' into force-login

7b85e8e

a0m0rajab mentioned this pull request May 30, 2023

Bug: QueryParams is not working supabase/supabase#14695

Closed

2 tasks

chore: add parse href

5713905

chore: fecth repos

904ae1a

a0m0rajab added 3 commits June 7, 2023 00:26

Merge branch 'beta' into force-login

c5a00f3

chore: add repos

fef7f60

Merge branch 'force-login' of https://github.com/a0m0rajab/insights i…

d167a22

…nto force-login

Merge branch 'beta' into force-login

dbbfbc2

a0m0rajab added 6 commits June 22, 2023 22:00

chore: add debugger

d71f995

chore: add logs

96bcd9c

chore: delete login in the useEffect

f672c1d

Revert "chore: delete login in the useEffect"

0def22d

This reverts commit f672c1d.

chore: add remove login to sign out

cfb3914

Merge branch 'beta' into force-login

914732e

brandonroberts approved these changes Jun 26, 2023

View reviewed changes

layouts/private-wrapper.tsx Outdated Show resolved Hide resolved

a0m0rajab added 2 commits June 26, 2023 18:55

chore: remove console log

14da63e

Merge branch 'beta' into force-login

f7cd091

OgDev-01 approved these changes Jun 26, 2023

View reviewed changes

brandonroberts merged commit 21aaa0b into open-sauced:beta Jun 26, 2023
10 checks passed

github-actions bot added the released on @beta label Jun 26, 2023

github-actions bot added the released label Jun 28, 2023

a0m0rajab deleted the force-login branch July 30, 2023 23:31

a0m0rajab mentioned this pull request Jul 30, 2023

Bug: redirect rules make viewing individual highlights difficult #1145

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: force login (close #1132) #1184

feat: force login (close #1132) #1184

a0m0rajab commented May 16, 2023

netlify bot commented May 16, 2023 •

edited

Loading

netlify bot commented May 16, 2023 •

edited

Loading

brandonroberts commented May 17, 2023

a0m0rajab commented May 22, 2023

brandonroberts commented May 23, 2023

a0m0rajab commented May 23, 2023

a0m0rajab commented May 30, 2023

brandonroberts commented May 30, 2023

a0m0rajab commented May 30, 2023

brandonroberts commented May 30, 2023 •

edited

Loading

OgDev-01 commented Jun 2, 2023

a0m0rajab commented Jun 2, 2023

a0m0rajab commented Jun 5, 2023 •

edited

Loading

takanome-dev commented Jun 6, 2023

a0m0rajab commented Jun 8, 2023

a0m0rajab commented Jun 21, 2023

brandonroberts commented Jun 22, 2023

a0m0rajab commented Jun 22, 2023

brandonroberts commented Jun 22, 2023

a0m0rajab commented Jun 22, 2023

a0m0rajab commented Jun 22, 2023

a0m0rajab commented Jun 23, 2023

brandonroberts left a comment

brandonroberts commented Jun 26, 2023

a0m0rajab commented Jun 26, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jun 28, 2023

feat: force login (close #1132) #1184

feat: force login (close #1132) #1184

Conversation

a0m0rajab commented May 16, 2023

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

netlify bot commented May 16, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented May 16, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

brandonroberts commented May 17, 2023

a0m0rajab commented May 22, 2023

brandonroberts commented May 23, 2023

a0m0rajab commented May 23, 2023

a0m0rajab commented May 30, 2023

brandonroberts commented May 30, 2023

a0m0rajab commented May 30, 2023

brandonroberts commented May 30, 2023 • edited Loading

OgDev-01 commented Jun 2, 2023

a0m0rajab commented Jun 2, 2023

a0m0rajab commented Jun 5, 2023 • edited Loading

takanome-dev commented Jun 6, 2023

a0m0rajab commented Jun 8, 2023

a0m0rajab commented Jun 21, 2023

brandonroberts commented Jun 22, 2023

a0m0rajab commented Jun 22, 2023

brandonroberts commented Jun 22, 2023

a0m0rajab commented Jun 22, 2023

a0m0rajab commented Jun 22, 2023

a0m0rajab commented Jun 23, 2023

brandonroberts left a comment

Choose a reason for hiding this comment

brandonroberts commented Jun 26, 2023

a0m0rajab commented Jun 26, 2023

github-actions bot commented Jun 26, 2023

github-actions bot commented Jun 28, 2023

netlify bot commented May 16, 2023 •

edited

Loading

netlify bot commented May 16, 2023 •

edited

Loading

brandonroberts commented May 30, 2023 •

edited

Loading

a0m0rajab commented Jun 5, 2023 •

edited

Loading