Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Star-Search markdown rendering isn't displaying rendered react-markdown HTML properly #3337

Closed
jpmcb opened this issue May 7, 2024 · 5 comments · Fixed by #3339
Closed
Assignees

Comments

@jpmcb
Copy link
Member

jpmcb commented May 7, 2024

Describe the bug

There appears to be something wrong with how the react-markdown gets rendered in the chat box for Star-Search. Primarily, the renderd HTML doesn't seem to be correctly displayed. For example, here's an H3 (that is properly rendered from a "###" in markdown) that doesn't get bolded or highlighted or anything:

Screenshot 2024-05-07 at 3 53 29 PM

Steps to reproduce

  1. Ask Star-Search a question
  2. Inspect the HTML
  3. See that the markdown was rendered but notice that it's HTML elements aren't observed correctly
@jpmcb jpmcb added 🐛 bug Something isn't working 👀 needs triage labels May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member

@jpmcb, the reason this happens is because tailwind by default removes default browser stylings. We can add some for the markdown rendered.

@nickytonline
Copy link
Member

nickytonline commented May 8, 2024

I have a fix that I will put up for this, e.g.
CleanShot 2024-05-07 at 21 04 58

Copy link

open-sauced bot commented May 8, 2024

🎉 This issue has been resolved in version 2.25.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

open-sauced bot commented May 9, 2024

🎉 This issue has been resolved in version 2.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants