Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now markdown has common styles #3339

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 8, 2024

Description

Adds some default styles for markdown renderer in StarSearch. It fixes headings and lists. @isabensusan, feel free to tweak my suggestions in globals.css.

Related Tickets & Documents

Fixes #3337

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-05-07 at 21 09 40

After

image

Steps to QA

  1. Ask Star-Search a question, e.g. "who is nickytonline and what has he written about recently?"
  2. Inspect the HTML
  3. See that the markdown was rendered and it has some base styling now (headings, lists)

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 8, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 6200d76
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/663ad2cfc1f9a400088914e5
😎 Deploy Preview https://deploy-preview-3339--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 6200d76
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/663ad2cf723d1800082198dd
😎 Deploy Preview https://deploy-preview-3339--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline force-pushed the nickytonline/markown-styling branch from 00b53c3 to f3c8db4 Compare May 8, 2024 01:13
@nickytonline
Copy link
Member Author

Sidenote @jpmcb, but I don't think we need those  s you added in a previous PR, or maybe not in all cases.

CleanShot 2024-05-07 at 21 14 45

@nickytonline nickytonline force-pushed the nickytonline/markown-styling branch from f3c8db4 to 6200d76 Compare May 8, 2024 01:18
@nickytonline nickytonline requested review from isabensusan and a team May 8, 2024 01:20
@nickytonline nickytonline merged commit 1db8260 into beta May 8, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/markown-styling branch May 8, 2024 18:53
open-sauced bot pushed a commit that referenced this pull request May 8, 2024
## [2.25.1-beta.1](v2.25.0...v2.25.1-beta.1) (2024-05-08)

### 🐛 Bug Fixes

* now markdown has common styles ([6200d76](6200d76))
* now markdown has common styles ([#3339](#3339)) ([1db8260](1db8260))
@jpmcb
Copy link
Member

jpmcb commented May 8, 2024

I don't think we need those  s you added in a previous PR, or maybe not in all cases.

cc @nickytonline - I honestly have no idea: the model seems to send empty data: chunks when it wants a new line. But I can't figure out a good way for it to render that via react-markdown since line breaks in markdown aren't really a well standardized thing.

So yeah, up to you how we approach this, already looks way way better in this PR.

open-sauced bot pushed a commit that referenced this pull request May 9, 2024
## [2.26.0](v2.25.0...v2.26.0) (2024-05-09)

### 🍕 Features

* add repository filtering to contributor insight activity page ([#3355](#3355)) ([58f6dda](58f6dda))
* implemented the substabs list component ([#3352](#3352)) ([5a55026](5a55026))
* implemented the workspace issues table ([#3340](#3340)) ([ba1bc51](ba1bc51))
* now low activity ratio pills are slate ([#3347](#3347)) ([18bd781](18bd781))

### 🐛 Bug Fixes

* now markdown has common styles ([6200d76](6200d76))
* now markdown has common styles ([#3339](#3339)) ([1db8260](1db8260))
* style tweaks for MultiSelect component ([#3354](#3354)) ([6cf9f99](6cf9f99))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Star-Search markdown rendering isn't displaying rendered react-markdown HTML properly
4 participants