Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap out css module prompt with lottery factor #3413

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented May 17, 2024

Description

The css modules example was flawed because that is not something matters or changes often in turbo. Instead, I'd rather include a question that highlights th work @nickytonline just shipped.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Click the lottery factor prompt.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

giphy (25)

Copy link

netlify bot commented May 17, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 6bf86e7
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6646d83589fd5c0008e21ea1
😎 Deploy Preview https://deploy-preview-3413--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 6bf86e7
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6646d835365f8a00081b796d
😎 Deploy Preview https://deploy-preview-3413--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie
Copy link
Member Author

bdougie commented May 17, 2024

using copilot workspaces to fix the box sizes.

Screenshot 2024-05-16 at 5 12 30 PM

Screenshot 2024-05-16 at 5 13 04 PM

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

pages/star-search/index.tsx Outdated Show resolved Hide resolved
pages/star-search/index.tsx Outdated Show resolved Hide resolved
@bdougie bdougie marked this pull request as ready for review May 17, 2024 04:09
@bdougie
Copy link
Member Author

bdougie commented May 17, 2024

@BekahHW with this change we can focus on these 4 prompts for launch.

@nickytonline nickytonline requested a review from BekahHW May 17, 2024 12:44
@nickytonline nickytonline merged commit 2c9def0 into beta May 17, 2024
13 checks passed
@nickytonline nickytonline deleted the bdougie-patch-1 branch May 17, 2024 12:50
open-sauced bot pushed a commit that referenced this pull request May 17, 2024
## [2.29.1-beta.1](v2.29.0...v2.29.1-beta.1) (2024-05-17)

### 🐛 Bug Fixes

* swap out css module prompt with lottery factor ([#3413](#3413)) ([2c9def0](2c9def0))
open-sauced bot pushed a commit that referenced this pull request May 21, 2024
## [2.30.0](v2.29.0...v2.30.0) (2024-05-21)

### 🍕 Features

* add workspaces intro video to welcome modal ([#3432](#3432)) ([d4bce9a](d4bce9a))
* added a loader for StarSearch responses ([#3422](#3422)) ([8972760](8972760))
* open up access to StarSearch and show modal/drawer for login ([#3442](#3442)) ([d228949](d228949))
* Small update to copy for suggested starsearch queries ([#3438](#3438)) ([012db59](012db59))
* update to lunch week card ([#3439](#3439)) ([d41f8fa](d41f8fa))
* Use StarSearchPayload from API ([#3424](#3424)) ([a8b01f7](a8b01f7))

### 🐛 Bug Fixes

* add mobile drawer for `InsightUpgradeModal` ([#3429](#3429)) ([d081980](d081980))
* add support for clipboard copy in Safari and use utility function ([#3433](#3433)) ([2d1b74f](2d1b74f))
* disable search for workspace dropdown if not logged in ([#3414](#3414)) ([b242e92](b242e92))
* fix to avoid StarSearch UI breaking when long words are outputted ([#3420](#3420)) ([4d6bb23](4d6bb23))
* fixed rendering of lottery chart when less than 4 contributors ([#3415](#3415)) ([3888ecb](3888ecb))
* fixed scrolling issues with StarSearch ([#3444](#3444)) ([2c46494](2c46494))
* history chart using correct data for `StarsChart` ([#3443](#3443)) ([f85f1fd](f85f1fd))
* now sauced-orange colour defaults to 1 for opacity ([#3437](#3437)) ([aa9f67f](aa9f67f))
* remove reactions from issues table ([#3435](#3435)) ([e15c6b6](e15c6b6))
* swap out css module prompt with lottery factor ([#3413](#3413)) ([2c9def0](2c9def0))
* updated StarSearch copy ([#3440](#3440)) ([abe33f1](abe33f1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants