-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added a loader for StarSearch responses #3422
Conversation
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Feels off. I'd rather figure out how to remove loader when component renders or look for a different solution. We can chat through this more next week. |
82acba5
to
75e388a
Compare
@bdougie, this was bugging me so I fixed the behaviour. Now the loader appears when a new prompt is sent and it disappears as soon as a valid response message starts streaming. Valid response meaning I filter out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works.
## [2.30.0-beta.1](v2.29.1-beta.4...v2.30.0-beta.1) (2024-05-21) ### 🍕 Features * added a loader for StarSearch responses ([#3422](#3422)) ([8972760](8972760))
## [2.30.0](v2.29.0...v2.30.0) (2024-05-21) ### 🍕 Features * add workspaces intro video to welcome modal ([#3432](#3432)) ([d4bce9a](d4bce9a)) * added a loader for StarSearch responses ([#3422](#3422)) ([8972760](8972760)) * open up access to StarSearch and show modal/drawer for login ([#3442](#3442)) ([d228949](d228949)) * Small update to copy for suggested starsearch queries ([#3438](#3438)) ([012db59](012db59)) * update to lunch week card ([#3439](#3439)) ([d41f8fa](d41f8fa)) * Use StarSearchPayload from API ([#3424](#3424)) ([a8b01f7](a8b01f7)) ### 🐛 Bug Fixes * add mobile drawer for `InsightUpgradeModal` ([#3429](#3429)) ([d081980](d081980)) * add support for clipboard copy in Safari and use utility function ([#3433](#3433)) ([2d1b74f](2d1b74f)) * disable search for workspace dropdown if not logged in ([#3414](#3414)) ([b242e92](b242e92)) * fix to avoid StarSearch UI breaking when long words are outputted ([#3420](#3420)) ([4d6bb23](4d6bb23)) * fixed rendering of lottery chart when less than 4 contributors ([#3415](#3415)) ([3888ecb](3888ecb)) * fixed scrolling issues with StarSearch ([#3444](#3444)) ([2c46494](2c46494)) * history chart using correct data for `StarsChart` ([#3443](#3443)) ([f85f1fd](f85f1fd)) * now sauced-orange colour defaults to 1 for opacity ([#3437](#3437)) ([aa9f67f](aa9f67f)) * remove reactions from issues table ([#3435](#3435)) ([e15c6b6](e15c6b6)) * swap out css module prompt with lottery factor ([#3413](#3413)) ([2c9def0](2c9def0)) * updated StarSearch copy ([#3440](#3440)) ([abe33f1](abe33f1))
Description
Now StarSearch has a loading animation before a response is streamed in.
Related Tickets & Documents
Close #3203
Mobile & Desktop Screenshots/Recordings
Before
After
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?