fix: disable search for workspace dropdown if not logged in #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Comment on lines
+123
to
+131
| if (!user) { | ||
| signIn({ | ||
| provider: "github", | ||
| options: { | ||
| redirectTo: `${new URL("/workspaces/new", window.location.href)}`, | ||
| }, | ||
| }); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is part of the fix for #2812.
BekahHW
approved these changes
May 17, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
May 17, 2024
## [2.29.1-beta.2](v2.29.1-beta.1...v2.29.1-beta.2) (2024-05-17) ### 🐛 Bug Fixes * disable search for workspace dropdown if not logged in ([#3414](#3414)) ([b242e92](b242e92))
open-sauced bot
pushed a commit
that referenced
this pull request
May 21, 2024
## [2.30.0](v2.29.0...v2.30.0) (2024-05-21) ### 🍕 Features * add workspaces intro video to welcome modal ([#3432](#3432)) ([d4bce9a](d4bce9a)) * added a loader for StarSearch responses ([#3422](#3422)) ([8972760](8972760)) * open up access to StarSearch and show modal/drawer for login ([#3442](#3442)) ([d228949](d228949)) * Small update to copy for suggested starsearch queries ([#3438](#3438)) ([012db59](012db59)) * update to lunch week card ([#3439](#3439)) ([d41f8fa](d41f8fa)) * Use StarSearchPayload from API ([#3424](#3424)) ([a8b01f7](a8b01f7)) ### 🐛 Bug Fixes * add mobile drawer for `InsightUpgradeModal` ([#3429](#3429)) ([d081980](d081980)) * add support for clipboard copy in Safari and use utility function ([#3433](#3433)) ([2d1b74f](2d1b74f)) * disable search for workspace dropdown if not logged in ([#3414](#3414)) ([b242e92](b242e92)) * fix to avoid StarSearch UI breaking when long words are outputted ([#3420](#3420)) ([4d6bb23](4d6bb23)) * fixed rendering of lottery chart when less than 4 contributors ([#3415](#3415)) ([3888ecb](3888ecb)) * fixed scrolling issues with StarSearch ([#3444](#3444)) ([2c46494](2c46494)) * history chart using correct data for `StarsChart` ([#3443](#3443)) ([f85f1fd](f85f1fd)) * now sauced-orange colour defaults to 1 for opacity ([#3437](#3437)) ([aa9f67f](aa9f67f)) * remove reactions from issues table ([#3435](#3435)) ([e15c6b6](e15c6b6)) * swap out css module prompt with lottery factor ([#3413](#3413)) ([2c9def0](2c9def0)) * updated StarSearch copy ([#3440](#3440)) ([abe33f1](abe33f1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the search on the workspace dropdown in the sidebar if there's no user logged in. Clicking the "Create new workspace" option will automatically log the user in using GitHub and redirect to
/workspace/newRelated Tickets & Documents
Closes #3377
Relates to #2812
Mobile & Desktop Screenshots/Recordings
Screen.Recording.2024-05-17.at.2.52.36.AM.mov
Steps to QA
WorkspaceLayout(ie repo pages) while NOT logged inCreate new workspaceoption/workspace/newAND logged you in via GitHub.Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?