Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix to avoid StarSearch UI breaking when long words are outputted #3420

Merged
merged 1 commit into from
May 17, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 17, 2024

Description

Fixes an issue in the StarSearch UI where chatboxes were expanding outside the viewport on small screens when long words were present in the prompt response.

Related Tickets & Documents

Fixes #3421

Mobile & Desktop Screenshots/Recordings

No screenshot atm but we debugged this together in our session @jpmcb @bdougie.

Steps to QA

Hard to test at the moment but if you get a response

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 17, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 2f87baa
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6647ca0fada3d70008b35fc8
😎 Deploy Preview https://deploy-preview-3420--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 2f87baa
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6647ca0f09f47500081910ba
😎 Deploy Preview https://deploy-preview-3420--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy (26)

@nickytonline nickytonline requested review from jpmcb and a team May 17, 2024 21:24
@nickytonline nickytonline merged commit 4d6bb23 into beta May 17, 2024
31 checks passed
@nickytonline nickytonline deleted the nickytonline/css-fix-star-search branch May 17, 2024 21:35
open-sauced bot pushed a commit that referenced this pull request May 17, 2024
## [2.29.1-beta.4](v2.29.1-beta.3...v2.29.1-beta.4) (2024-05-17)

### 🐛 Bug Fixes

* fix to avoid StarSearch UI breaking when long words are outputted ([#3420](#3420)) ([4d6bb23](4d6bb23))
@jpmcb jpmcb mentioned this pull request May 20, 2024
4 tasks
open-sauced bot pushed a commit that referenced this pull request May 21, 2024
## [2.30.0](v2.29.0...v2.30.0) (2024-05-21)

### 🍕 Features

* add workspaces intro video to welcome modal ([#3432](#3432)) ([d4bce9a](d4bce9a))
* added a loader for StarSearch responses ([#3422](#3422)) ([8972760](8972760))
* open up access to StarSearch and show modal/drawer for login ([#3442](#3442)) ([d228949](d228949))
* Small update to copy for suggested starsearch queries ([#3438](#3438)) ([012db59](012db59))
* update to lunch week card ([#3439](#3439)) ([d41f8fa](d41f8fa))
* Use StarSearchPayload from API ([#3424](#3424)) ([a8b01f7](a8b01f7))

### 🐛 Bug Fixes

* add mobile drawer for `InsightUpgradeModal` ([#3429](#3429)) ([d081980](d081980))
* add support for clipboard copy in Safari and use utility function ([#3433](#3433)) ([2d1b74f](2d1b74f))
* disable search for workspace dropdown if not logged in ([#3414](#3414)) ([b242e92](b242e92))
* fix to avoid StarSearch UI breaking when long words are outputted ([#3420](#3420)) ([4d6bb23](4d6bb23))
* fixed rendering of lottery chart when less than 4 contributors ([#3415](#3415)) ([3888ecb](3888ecb))
* fixed scrolling issues with StarSearch ([#3444](#3444)) ([2c46494](2c46494))
* history chart using correct data for `StarsChart` ([#3443](#3443)) ([f85f1fd](f85f1fd))
* now sauced-orange colour defaults to 1 for opacity ([#3437](#3437)) ([aa9f67f](aa9f67f))
* remove reactions from issues table ([#3435](#3435)) ([e15c6b6](e15c6b6))
* swap out css module prompt with lottery factor ([#3413](#3413)) ([2c9def0](2c9def0))
* updated StarSearch copy ([#3440](#3440)) ([abe33f1](abe33f1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: StarSearch UI Chatboxes expand on small screens when long words present
3 participants