Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Remove links from HighlightCards #407

Closed
Tracked by #374
eryc-cc opened this issue Sep 20, 2022 · 5 comments · Fixed by #435
Closed
Tracked by #374

bug: Remove links from HighlightCards #407

eryc-cc opened this issue Sep 20, 2022 · 5 comments · Fixed by #435
Assignees
Labels
🐛 bug Something isn't working ⚡️ easy win An issue that's easy to complete. released on @beta released

Comments

@eryc-cc
Copy link
Contributor

eryc-cc commented Sep 20, 2022

Summary

I don't know if it makes sense for us to have the HighlightCards linked anymore...

We can add more functionality to these cards if we don't have links to other tabs, like "share on twitter", etc.

@eryc-cc eryc-cc changed the title Remove links from HighlightCards bug: Remove links from HighlightCards Sep 20, 2022
@eryc-cc eryc-cc added 🐛 bug Something isn't working ⚡️ easy win An issue that's easy to complete. labels Sep 20, 2022
@eryc-cc
Copy link
Contributor Author

eryc-cc commented Sep 20, 2022

@bdougie what do you think about this?

@bdougie
Copy link
Member

bdougie commented Sep 20, 2022

Correct. I don't think we need to enforce that connection but can always re-introduce as we explore more customer feedback in the future. But let's remove the link to keep things simple and not confuse the users.

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.7.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.8.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⚡️ easy win An issue that's easy to complete. released on @beta released
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants