Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove link from highlight card component #435

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

OgDev-01
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

The PR removes link from the highlight card component

Related Tickets & Documents

Fixes #407

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 26, 2022

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit d657a18
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6331c86ac13860000caa4c1e
😎 Deploy Preview https://deploy-preview-435--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 26, 2022

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit d657a18
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6331c86a17ba8c00090276d0
😎 Deploy Preview https://deploy-preview-435--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@OgDev-01
Copy link
Contributor Author

@bdougie @pixelsbyeryc

I'll merge this as this is not qualified for a review πŸ‘Œ

@bdougie
Copy link
Member

bdougie commented Sep 26, 2022

Be sure to squash

@OgDev-01 OgDev-01 merged commit 25b6997 into beta Sep 26, 2022
@OgDev-01 OgDev-01 deleted the 407-remove-links-from-highlight-card branch September 26, 2022 16:07
github-actions bot pushed a commit that referenced this pull request Sep 26, 2022
## [1.7.0-beta.9](v1.7.0-beta.8...v1.7.0-beta.9) (2022-09-26)

### πŸ› Bug Fixes

* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.7.0-beta.9 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
## [1.8.0-beta.1](v1.7.0...v1.8.0-beta.1) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.8.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Sep 28, 2022
## [1.8.0](v1.7.0...v1.8.0) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](#431)) ([56e12ea](56e12ea)), closes [#404](#404)
* Add truncate string for long pr names ([#440](#440)) ([35b8541](35b8541)), closes [#438](#438)
* adds initial support for restricting reports by user roles ([#451](#451)) ([15a7643](15a7643)), closes [#395](#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](#432)) ([7adfbe7](7adfbe7))
* inverse the scatter chart ([#433](#433)) ([18dd094](18dd094)), closes [#399](#399)
* limit number of languages in contibutor's card ([#441](#441)) ([4aba355](4aba355)), closes [#402](#402)
* remove link from highlight card component ([#435](#435)) ([25b6997](25b6997))
* remove remaining mock data for contributors ([#443](#443)) ([974c739](974c739)), closes [#404](#404) [#444](#444)
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.8.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.7.0-beta.9](open-sauced/app@v1.7.0-beta.8...v1.7.0-beta.9) (2022-09-26)

### πŸ› Bug Fixes

* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.8.0-beta.1](open-sauced/app@v1.7.0...v1.8.0-beta.1) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.8.0](open-sauced/app@v1.7.0...v1.8.0) (2022-09-28)

### πŸ• Features

* add data from API to contributors page for hacktoberfest ([#431](open-sauced/app#431)) ([56e12ea](open-sauced/app@56e12ea)), closes [#404](open-sauced/app#404)
* Add truncate string for long pr names ([#440](open-sauced/app#440)) ([35b8541](open-sauced/app@35b8541)), closes [#438](open-sauced/app#438)
* adds initial support for restricting reports by user roles ([#451](open-sauced/app#451)) ([15a7643](open-sauced/app@15a7643)), closes [#395](open-sauced/app#395)

### πŸ› Bug Fixes

* adds links to footer ([#432](open-sauced/app#432)) ([7adfbe7](open-sauced/app@7adfbe7))
* inverse the scatter chart ([#433](open-sauced/app#433)) ([18dd094](open-sauced/app@18dd094)), closes [#399](open-sauced/app#399)
* limit number of languages in contibutor's card ([#441](open-sauced/app#441)) ([4aba355](open-sauced/app@4aba355)), closes [#402](open-sauced/app#402)
* remove link from highlight card component ([#435](open-sauced/app#435)) ([25b6997](open-sauced/app@25b6997))
* remove remaining mock data for contributors ([#443](open-sauced/app#443)) ([974c739](open-sauced/app@974c739)), closes [#404](open-sauced/app#404) [#444](open-sauced/app#444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Remove links from HighlightCards
2 participants