Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Reports History Component #209

Merged
merged 12 commits into from
Aug 20, 2022
Merged

feat: Implement Reports History Component #209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6449663
Initial commit for reports history component.
chadstewart Aug 16, 2022
165846b
Updated Card component to accept a heading and display it properly.
chadstewart Aug 16, 2022
6bc752a
Making progress on reports history page. Making the segments for each…
chadstewart Aug 16, 2022
10ee28e
Updated Card to accept both a JSX element or a string and updated the…
chadstewart Aug 16, 2022
b60e165
Completed Reports History component. Working on clean up now.
chadstewart Aug 16, 2022
f4a7068
Just doing a bit of clean up to the code.
chadstewart Aug 16, 2022
7276c44
Removing hard-coded width percentages from reports history component.
chadstewart Aug 16, 2022
c990988
Updated report type to only accept CSV string for now.
chadstewart Aug 17, 2022
368fd86
Made some changes based on review feedback.
chadstewart Aug 18, 2022
bfd2dee
Updated report history and card component based on review feedback.
chadstewart Aug 19, 2022
a2abf42
Updated reports history based on code review.
chadstewart Aug 19, 2022
266993c
Made some changes to reports-history based on code review.
chadstewart Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/atoms/Card/card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const Card: React.FC<CardProps> = ({ className, children, heading }) => {
<div className="px-6 py-3 rounded-t-lg bg-light-slate-3">
{heading}
</div>
<div className="p-6">
<div className="py-6">
chadstewart marked this conversation as resolved.
Show resolved Hide resolved
{children}
</div>
</>
Expand Down
24 changes: 12 additions & 12 deletions components/molecules/ReportsHistory/reports-history.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,44 +10,44 @@ interface ReportsHistoryProps {

const ReportsHistory = ({ reportList }: ReportsHistoryProps): JSX.Element => {
const heading = <Title level={5} className="!text-light-slate-9 uppercase">
<div className="flex justify-between w-full">
<div className="w-2/5 border-1 p-2">
<div className="flex justify-between w-full gap-2">
<div className="w-2/5 font-xs font-semibold text-slate-400 tracking-wide uppercase">
chadstewart marked this conversation as resolved.
Show resolved Hide resolved
report date
</div>
<div className="w-1/5 border-1 p-2">
<div className="w-1/5 font-xs font-semibold text-slate-400 tracking-wide uppercase">
issue date
</div>
<div className="w-1/5 border-1 p-2">
<div className="w-1/5 font-xs font-semibold text-slate-400 tracking-wide uppercase">
format
</div>
<div className="w-1/5 border-1 p-2">
<div className="w-1/5 font-xs font-semibold text-slate-400 tracking-wide uppercase">
{null}
</div>
</div>
</Title>;

return (
<Card heading={heading}>
<div className="flex flex-col justify-between w-full">
<div className="flex flex-col justify-between w-full gap-2">
{reportList ?
reportList.map(({reportDate, reportName, reportFormat, isGenerated}, index) =>
<div className="flex" key={index}>
<div className="w-2/5 border-1 p-2">
<div className={`flex py-3 ${index % 2 === 0 ? "bg-slate-50" : "bg-white"}`} key={index}>
<div className="w-2/5 px-6 font-sm font-medium text-slate-900 tracking-tight">
chadstewart marked this conversation as resolved.
Show resolved Hide resolved
{reportName}
</div>
<div className="w-1/5 border-1 p-2">
<div className="w-1/5 px-6 font-sm font-medium text-slate-900 tracking-tight">
{reportDate}
</div>
<div className="w-1/5 border-1 p-2">
<div className="w-1/5 px-6 font-sm font-medium text-slate-900 tracking-tight">
{reportFormat}
</div>
<div className="w-1/5 border-1 p-2">
<div className="w-1/5 px-6 font-sm font-medium text-slate-900 tracking-tight text-right">
{isGenerated ?
<Button type="link" >Download</Button>

:

<Button type="link" className="!text-light-slate-10" disabled >Generating</Button>
<Button type="link" className="!text-light-slate-10" disabled >Generating...</Button>
}
</div>
</div>
Expand Down