Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Reports History Component #209

Merged
merged 12 commits into from
Aug 20, 2022
Merged

feat: Implement Reports History Component #209

merged 12 commits into from
Aug 20, 2022

Conversation

chadstewart
Copy link
Contributor

@chadstewart chadstewart commented Aug 16, 2022 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This PR adds the feature of the Reports History Component

Details:

  • Extended the Card Component to now have accept a string or direct JSX for it's header.
    • Why: The header design was new for the Card component and I felt that could have been reused through the app so it made sense to extend the Card component
  • The Reports History component accepts an array of objects that are described in the reports type and maps that array out.
    • If no array is passed, it will out a string that there are currently no arrays.

Related Tickets & Documents

Fixes #167

Mobile & Desktop Screenshots/Recordings

deploy-preview-209--design-insights netlify app__path=_story_design-system-molecules-reports-history--default
deploy-preview-209--design-insights netlify app__path=_story_design-system-molecules-reports-history--no-reports

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 266993c
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63002fd0707e240008ad6d4f
😎 Deploy Preview https://deploy-preview-209--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 266993c
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63002fd0707e240008ad6d51
😎 Deploy Preview https://deploy-preview-209--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chadstewart chadstewart marked this pull request as ready for review August 17, 2022 12:13
@chadstewart
Copy link
Contributor Author

Quick question. Can someone critique my description of this PR? I'm naturally a big block of text type of writer and so I just want to make sure I'm not conveying too much information or not in a good enough way to provide context.

@0-vortex
Copy link
Contributor

Quick question. Can someone critique my description of this PR? I'm naturally a big block of text type of writer and so I just want to make sure I'm not conveying too much information or not in a good enough way to provide context.

Use unordered lists:

  • one per statement
  • or category

🍕

eryc-cc
eryc-cc suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@eryc-cc eryc-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sums the design review! Great job so far, @chadstewart! 🙌

@OgDev-01 OgDev-01 mentioned this pull request Aug 18, 2022
Merged
19 tasks
eryc-cc
eryc-cc suggested changes Aug 18, 2022
View reviewed changes
components/molecules/ReportsHistory/reports-history.tsx Outdated Show resolved Hide resolved
components/atoms/Card/card.tsx Outdated Show resolved Hide resolved
components/molecules/ReportsHistory/reports-history.tsx Outdated Show resolved Hide resolved
components/atoms/Card/card.tsx Outdated Show resolved Hide resolved
@chadstewart chadstewart added the needs review PRs that need review from core engineering team label Aug 19, 2022
0-vortex
0-vortex approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but going a little into less functional rogue territory with that element or string and unstandardised heading usage! 👍 🍕

components/atoms/Card/card.tsx Show resolved Hide resolved
eryc-cc
eryc-cc approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@eryc-cc eryc-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks perfect 🍕

@chadstewart chadstewart mentioned this pull request Aug 20, 2022
Closed
@chadstewart chadstewart merged commit bb531e4 into beta Aug 20, 2022
@chadstewart chadstewart deleted the 167-reports-history-component branch August 20, 2022 11:57
github-actions bot pushed a commit that referenced this pull request Aug 20, 2022
@chadstewart @open-sauced
chore(minor): release 1.3.0-beta.1 on beta channel [skip ci]
8ffa850 
## [1.3.0-beta.1](v1.2.0...v1.3.0-beta.1) (2022-08-20)

### 🍕 Features

* Implement Reports History Component ([#209](#209)) ([bb531e4](bb531e4))
@github-actions
Copy link

🎉 This PR is included in version 1.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 29, 2022
@bdougie @open-sauced
chore(minor): release 1.3.0 [skip ci]
3d9103f 
## [1.3.0](v1.2.3...v1.3.0) (2022-08-29)

### 🧑‍💻 Code Refactoring

* Improve the `<ComponentCard>` CSS ([#266](#266)) ([9da4d62](9da4d62))
* Make the avatar component accept custom sizes ([#255](#255)) ([9076e91](9076e91)), closes [#235](#235)

### 🍕 Features

* Add Images to Scatter Chart ([#257](#257)) ([20df419](20df419))
* Add item count meta data to Highlight Card ([#254](#254)) ([693479e](693479e))
* Added Reports History component to Reports Page ([#272](#272)) ([c6a56f6](c6a56f6))
* Implement Card Horizontal Bar component ([#237](#237)) ([7bbbe40](7bbbe40))
* Implement Card Table Component ([#243](#243)) ([0cbc6ea](0cbc6ea))
* Implement contribution page ([#263](#263)) ([f41d7f9](f41d7f9))
* Implement Contributor Card Component ([#245](#245)) ([3bd55ea](3bd55ea))
* Implement Reports History Component ([#209](#209)) ([bb531e4](bb531e4))
* Implement the hacktoberfest reports page ([#229](#229)) ([0cfa5e5](0cfa5e5)), closes [#168](#168)
* Implement waitlist page ([#210](#210)) ([0826d07](0826d07)), closes [#152](#152)

### 🐛 Bug Fixes

* adjusted opinion filter on mobile screens ([#264](#264)) ([2d9785c](2d9785c))
* correct login redirect issues in supabase implemetation ([#274](#274)) ([8fcd81e](8fcd81e))
* correct login redirect issues in supabase implemetation x2 ([#275](#275)) ([0239abd](0239abd))
* correct supabase-ui default style for hover ([#267](#267)) ([a23fe4b](a23fe4b)), closes [#226](#226)
* increase truncate string number of words ([#268](#268)) ([ab47a96](ab47a96)), closes [#247](#247)
* max width removed from card ([#250](#250)) ([523969a](523969a)), closes [#249](#249)
* removes unused function ([b37de35](b37de35))
* Repo count ([#244](#244)) ([d59eef8](d59eef8))
* Update GitSense API route for repos ([#270](#270)) ([8f7e1c5](8f7e1c5))
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
@ElpisHelle
chore(minor): release 1.3.0-beta.1 on beta channel [skip ci]
82509c9 
## [1.3.0-beta.1](open-sauced/app@v1.2.0...v1.3.0-beta.1) (2022-08-20)

### 🍕 Features

* Implement Reports History Component ([#209](open-sauced/app#209)) ([bb531e4](open-sauced/app@bb531e4))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
@ElpisHelle
chore(minor): release 1.3.0 [skip ci]
fd90a60 
## [1.3.0](open-sauced/app@v1.2.3...v1.3.0) (2022-08-29)

### 🧑‍💻 Code Refactoring

* Improve the `<ComponentCard>` CSS ([#266](open-sauced/app#266)) ([9da4d62](open-sauced/app@9da4d62))
* Make the avatar component accept custom sizes ([#255](open-sauced/app#255)) ([9076e91](open-sauced/app@9076e91)), closes [#235](open-sauced/app#235)

### 🍕 Features

* Add Images to Scatter Chart ([#257](open-sauced/app#257)) ([20df419](open-sauced/app@20df419))
* Add item count meta data to Highlight Card ([#254](open-sauced/app#254)) ([693479e](open-sauced/app@693479e))
* Added Reports History component to Reports Page ([#272](open-sauced/app#272)) ([c6a56f6](open-sauced/app@c6a56f6))
* Implement Card Horizontal Bar component ([#237](open-sauced/app#237)) ([7bbbe40](open-sauced/app@7bbbe40))
* Implement Card Table Component ([#243](open-sauced/app#243)) ([0cbc6ea](open-sauced/app@0cbc6ea))
* Implement contribution page ([#263](open-sauced/app#263)) ([f41d7f9](open-sauced/app@f41d7f9))
* Implement Contributor Card Component ([#245](open-sauced/app#245)) ([3bd55ea](open-sauced/app@3bd55ea))
* Implement Reports History Component ([#209](open-sauced/app#209)) ([bb531e4](open-sauced/app@bb531e4))
* Implement the hacktoberfest reports page ([#229](open-sauced/app#229)) ([0cfa5e5](open-sauced/app@0cfa5e5)), closes [#168](open-sauced/app#168)
* Implement waitlist page ([#210](open-sauced/app#210)) ([0826d07](open-sauced/app@0826d07)), closes [#152](open-sauced/app#152)

### 🐛 Bug Fixes

* adjusted opinion filter on mobile screens ([#264](open-sauced/app#264)) ([2d9785c](open-sauced/app@2d9785c))
* correct login redirect issues in supabase implemetation ([#274](open-sauced/app#274)) ([8fcd81e](open-sauced/app@8fcd81e))
* correct login redirect issues in supabase implemetation x2 ([#275](open-sauced/app#275)) ([0239abd](open-sauced/app@0239abd))
* correct supabase-ui default style for hover ([#267](open-sauced/app#267)) ([a23fe4b](open-sauced/app@a23fe4b)), closes [#226](open-sauced/app#226)
* increase truncate string number of words ([#268](open-sauced/app#268)) ([ab47a96](open-sauced/app@ab47a96)), closes [#247](open-sauced/app#247)
* max width removed from card ([#250](open-sauced/app#250)) ([523969a](open-sauced/app@523969a)), closes [#249](open-sauced/app#249)
* removes unused function ([b37de35](open-sauced/app@b37de35))
* Repo count ([#244](open-sauced/app#244)) ([d59eef8](open-sauced/app@d59eef8))
* Update GitSense API route for repos ([#270](open-sauced/app#270)) ([8f7e1c5](open-sauced/app@8f7e1c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OgDev-01 OgDev-01 OgDev-01 left review comments

@0-vortex 0-vortex 0-vortex approved these changes

@eryc-cc eryc-cc eryc-cc approved these changes

@bdougie bdougie Awaiting requested review from bdougie

Assignees
No one assigned
Labels
needs review PRs that need review from core engineering team released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chadstewart @0-vortex @OgDev-01 @eryc-cc @bdougie