refactor: show banner across workspace when limits are exceeded #3233
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
This looks good. The only thing we need to handle is on smaller screens, the modal will be too large. We can use the drawer component for that. I can sync with you in the AM about that @brandonroberts.
|
What I see in mobile. Iphone 15
|
|
The banner should be good now @bdougie @brandonroberts
|
## [2.21.0-beta.6](v2.21.0-beta.5...v2.21.0-beta.6) (2024-04-25) ### 🧑💻 Code Refactoring * show banner across workspace when limits are exceeded ([#3233](#3233)) ([f0d1dac](f0d1dac))
## [2.21.0](v2.20.0...v2.21.0) (2024-04-25) ### 🐛 Bug Fixes * now StarSearch responses with links have styled links ([#3236](#3236)) ([99e622e](99e622e)) * now suggestion prompts run immediately ([#3242](#3242)) ([662d0b5](662d0b5)) ### 🍕 Features * add OG image to StarSearch waitlist ([#3245](#3245)) ([8563264](8563264)) * add share button to repo pages ([#3235](#3235)) ([cde9d62](cde9d62)) * implemented StarSearch waitlist ([#3231](#3231)) ([654d525](654d525)) * update stars and forks stats on repo pages ([#3199](#3199)) ([43ffce4](43ffce4)) ### 🧑💻 Code Refactoring * show banner across workspace when limits are exceeded ([#3233](#3233)) ([f0d1dac](f0d1dac))
Description
Related Tickets & Documents
Closes #3210
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?