Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nudge bottom banner for non logged in users #3259

Merged
merged 5 commits into from
May 1, 2024

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented Apr 25, 2024

Description

Implements a nudge bottom banner for non logged in users, urging them to sign up.

Related Tickets & Documents

Closes #3083

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit bd9fbff
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66325191a9b1470008260c13
😎 Deploy Preview https://deploy-preview-3259--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit bd9fbff
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66325191182a880008f99bf2
😎 Deploy Preview https://deploy-preview-3259--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua requested a review from a team April 25, 2024 21:14
@zeucapua
Copy link
Contributor Author

Added a button to close the nudge banner. It resets on every page for now since I used useState; I assume that we want to keep showing it as they navigate through workspaces and not lose a possible conversion

image

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for me.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandonroberts brandonroberts merged commit ea88536 into beta May 1, 2024
13 checks passed
@brandonroberts brandonroberts deleted the feat/mobile-signup-banner-nudge branch May 1, 2024 14:54
open-sauced bot pushed a commit that referenced this pull request May 1, 2024
## [2.23.0-beta.1](v2.22.1-beta.1...v2.23.0-beta.1) (2024-05-01)

### 🍕 Features

* add nudge bottom banner for non logged in users ([#3259](#3259)) ([ea88536](ea88536))
open-sauced bot pushed a commit that referenced this pull request May 1, 2024
## [2.23.0](v2.22.0...v2.23.0) (2024-05-01)

### 🐛 Bug Fixes

* repository page speed improvements ([#3269](#3269)) ([fcbf89d](fcbf89d))

### 🍕 Features

* add nudge bottom banner for non logged in users ([#3259](#3259)) ([ea88536](ea88536))
* implement 'Add to workspace' in repo pages ([#3282](#3282)) ([b1efc46](b1efc46))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Create a bottom banner in sidebar for non logged in users to sign up
4 participants