fix: filter out undefined values for building workspace owners array

[brandonroberts]

Description

• Fixes a bug where a workspaces has owners and viewers, which causes an error in getServerSideProps when undefined is returned in the owners array

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

1. Navigate to a workspace with an owner and viewer
2. Go to a contributor insight
3. Note the page loads correctly

Tier (staff will fill in)

• Tier 1
• Tier 2
• Tier 3
• Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

[netlify]

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	eb3ebe0
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/6633dd40f776bb0009fd0022
😎 Deploy Preview	https://deploy-preview-3305--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	eb3ebe0
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/6633dd4045bf07000873e397
😎 Deploy Preview	https://deploy-preview-3305--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jpmcb]

when undefined is returned in the owners array

That's surprising since my assumption was that the "members": [] would always have at least one member/owner. I thought we had blocked removing all members from a workspace (or at least owners could not remove themselves)

Or maybe it's something else? I'm very curious why this would be getting undefined in the members array.

[brandonroberts]

when undefined is returned in the owners array

That's surprising since my assumption was that the "members": [] would always have at least one member/owner. I thought we had blocked removing all members from a workspace (or at least owners could not remove themselves)

Or maybe it's something else? I'm very curious why this would be getting undefined in the members array.

The data is correct

[
  { "login": "me", "role": "owner" },
  { "login": "you", "role": "viewer" },
]

  const owners = Array.from(workspaceMembers?.data || [], (member: { role: string; member: Record<string, any> }) => {
    if (member.role === "owner") {
      return member.member.login;
    }
  }); // without the filter

['me', undefined]

If its an owner, the login is returned. If its not, undefined is returned. Then when getServersideProps tries to serialize the data, if fails

[nickytonline]

🚢

[jpmcb]

Thanks for explaining !!!!!!!!!! 🧠 ◀️ 🥇