Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent fetching contributor and repo insights for new workspaceId #3419

Merged
merged 2 commits into from
May 23, 2024

Conversation

brandonroberts
Copy link
Contributor

Description

  • Fixes an issue where the workspaceId is set to new, causing 500s in the API
  • Adds check if its a new workspaceId, to not fetch the data for contributor and repository insights

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

  1. Go to deploy preview without being logged in
  2. Open up developer tools
  3. Visit a repo page
  4. Note no 500s are present in the network requests to the API

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@brandonroberts brandonroberts requested a review from a team May 17, 2024 19:56
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit a3ad0dd
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/664e9fff66a87c00086c92ce
😎 Deploy Preview https://deploy-preview-3419--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit a3ad0dd
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/664e9fff5da0c7000818e76c
😎 Deploy Preview https://deploy-preview-3419--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandonroberts brandonroberts merged commit 6334df1 into beta May 23, 2024
13 checks passed
@brandonroberts brandonroberts deleted the fix-sidebar-workspace-new branch May 23, 2024 02:16
open-sauced bot pushed a commit that referenced this pull request May 23, 2024
## [2.31.0-beta.3](v2.31.0-beta.2...v2.31.0-beta.3) (2024-05-23)

### 🐛 Bug Fixes

* now avatar for logged in user appears for StarSearch prompt ([#3454](#3454)) ([9994b06](9994b06))
* prevent fetching contributor and repo insights for new workspaceId ([#3419](#3419)) ([6334df1](6334df1))
open-sauced bot pushed a commit that referenced this pull request May 23, 2024
## [2.31.0](v2.30.0...v2.31.0) (2024-05-23)

### ✅ Tests

* added E2E tests for StarSearch logged out experience ([#3449](#3449)) ([63e6a93](63e6a93))

### 🍕 Features

* add hallucination disclaimer to `/star-search` ([#3450](#3450)) ([3019ef2](3019ef2))
* added hover cards to StarSearch results that return links to GitHub users ([#3461](#3461)) ([254e5e1](254e5e1))
* now /u/some_username redirects to /user/some_username ([#3458](#3458)) ([312c231](312c231))
* show `/star-search` suggestions as carousel ([#3431](#3431)) ([3160c1d](3160c1d))

### 🐛 Bug Fixes

* height style tweaks for StarSearch ([#3464](#3464)) ([3af57ff](3af57ff))
* now avatar for logged in user appears for StarSearch prompt ([#3454](#3454)) ([9994b06](9994b06))
* now clear history and feedback buttons are always just under the last StarSearch response ([#3455](#3455)) ([7561553](7561553))
* now StarSearch prompt/response area no longer scrolls when opening/closing suggestions ([#3448](#3448)) ([41b49a7](41b49a7))
* now StarSearch widgets have a max width of 440px and are centered in the card ([#3451](#3451)) ([3657d65](3657d65))
* prevent fetching contributor and repo insights for new workspaceId ([#3419](#3419)) ([6334df1](6334df1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants