Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:StarSearch link in smaller screen #3426

Closed
wants to merge 3 commits into from

Conversation

GitHub-Sanjit
Copy link

@GitHub-Sanjit GitHub-Sanjit commented May 19, 2024

Description

In smaller screen starSearch link is updated with tag from next/image

Related Tickets & Documents

Fixes #3263

Copy link

netlify bot commented May 19, 2024

‼️ Deploy request for oss-insights rejected.

Name Link
🔨 Latest commit 37370ba

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link

netlify bot commented May 19, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 37370ba
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/664986ccd29b120008b59cda
😎 Deploy Preview https://deploy-preview-3426--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GitHub-Sanjit GitHub-Sanjit changed the title [FIX]StarSearch link in smaller screen with <Image /> tag from next/image [FIX]StarSearch link in smaller screen May 19, 2024
@GitHub-Sanjit GitHub-Sanjit changed the title [FIX]StarSearch link in smaller screen fix:StarSearch link in smaller screen May 19, 2024
@jpmcb
Copy link
Member

jpmcb commented May 20, 2024

Thanks for the contribution @GitHub-Sanjit - the starsearch link was explicitly removed from the app sidebar in: #3374 and we are planning to come back to this design after we launch some of these features.

@jpmcb jpmcb closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants