Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now StarSearch remains visible on smaller screens in the top menu #3374

Merged

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented May 13, 2024

Description

Now StarSearch remains visible on smaller screens in the top menu.

Related Tickets & Documents

Fixes #3371

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-05-13 at 19 08 52

After

CleanShot 2024-05-13 at 18 59 27

Steps to QA

  1. Go to any page and resize it to a small size.
  2. Notice StarSearch remains in the menu.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 13, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 69f73e9
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66436dfcef5b96000860550e
😎 Deploy Preview https://deploy-preview-3374--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 69f73e9
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66436dfc1d707600086e7605
😎 Deploy Preview https://deploy-preview-3374--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline force-pushed the nickytonline/3371-star-search-visible-small-screen-menu branch from 2557e8b to ee74be8 Compare May 13, 2024 23:23
@nickytonline nickytonline requested a review from a team May 13, 2024 23:23
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quick fix but I'd love to come back to this on another pass post launch @isabensusan

@nickytonline nickytonline merged commit d6d0048 into beta May 14, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/3371-star-search-visible-small-screen-menu branch May 14, 2024 14:02
open-sauced bot pushed a commit that referenced this pull request May 14, 2024
## [2.27.0-beta.3](v2.27.0-beta.2...v2.27.0-beta.3) (2024-05-14)

### 🐛 Bug Fixes

* now StarSearch remains visible on smaller screens in the top menu ([#3374](#3374)) ([d6d0048](d6d0048))
open-sauced bot pushed a commit that referenced this pull request May 15, 2024
## [2.27.0](v2.26.0...v2.27.0) (2024-05-15)

### 🍕 Features

* Contributors tab for Repo pages ([#3342](#3342)) ([f1142c3](f1142c3))
* Lottery Factor chart for Repo pages ([#3343](#3343)) ([deda50e](deda50e))

### 🐛 Bug Fixes

* now opening workspace dropdown puts focus on search input ([#3364](#3364)) ([bafa0e4](bafa0e4))
* now StarSearch remains visible on smaller screens in the top menu ([#3374](#3374)) ([d6d0048](d6d0048))
* temporarily returning for event: function_call in readable stream from StarSearch ([#3379](#3379)) ([f6f4b01](f6f4b01))
* title for PR chart tooltip ([#3350](#3350)) ([56b2746](56b2746))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Make Star Search feature visible on mobile for other pages
3 participants