Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now app sidebar menu items have the same font weight #3690

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Jul 4, 2024

Description

Now top level app sidebar menu items have the same font weight.

Related Tickets & Documents

Fixes #3689

Mobile & Desktop Screenshots/Recordings

Before and then After (subtle)

CleanShot 2024-07-04 at 19 28 51

Steps to QA

  1. Open any page with the sidebar logged in.
  2. Notice the font weights are the same.
  3. Wait for @brandonroberts to post this animated GIF in his approval comment.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit d252908
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66872fca4021f60008d29716
😎 Deploy Preview https://deploy-preview-3690--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit d252908
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66872fca568d070008f5b174
😎 Deploy Preview https://deploy-preview-3690--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from isabensusan and a team July 4, 2024 23:28
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickytonline nickytonline merged commit 3647252 into beta Jul 5, 2024
25 checks passed
@nickytonline nickytonline deleted the nickytonline/fix-sidebar-font-styles branch July 5, 2024 20:59
open-sauced bot pushed a commit that referenced this pull request Jul 5, 2024
## [2.42.1-beta.1](v2.42.0...v2.42.1-beta.1) (2024-07-05)

### 🐛 Bug Fixes

* now app sidebar menu items have the same font weight ([#3690](#3690)) ([3647252](3647252))
open-sauced bot pushed a commit that referenced this pull request Jul 9, 2024
## [2.43.0](v2.42.0...v2.43.0) (2024-07-09)

### 🍕 Features

* `YoloChart` in repo pages ([#3658](#3658)) ([9462519](9462519))

### 🐛 Bug Fixes

* now app sidebar menu items have the same font weight ([#3690](#3690)) ([3647252](3647252))
* now the repository insights pages header looks good on smaller screens ([#3687](#3687)) ([8a47e17](8a47e17))
* use explore page with typescript topic as fallback instead of feed page ([#3691](#3691)) ([a50e34a](a50e34a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: font weights differ for app sidebar top level menu items
3 participants