Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front-End] Implement UI for User Login Component #4

Closed
2 tasks done
chadstewart opened this issue Jul 6, 2022 · 5 comments · Fixed by #96
Closed
2 tasks done

[Front-End] Implement UI for User Login Component #4

chadstewart opened this issue Jul 6, 2022 · 5 comments · Fixed by #96

Comments

@chadstewart
Copy link
Contributor

chadstewart commented Jul 6, 2022

Currently, the User Login Component is completely static with a static image and no drop down menu.

Image

This needs at least a drop down menu implemented with a user login link when the user is logged in and a user logout link when there is no logged in user.

This does not need to implement login functionality as yet but the UI needs to be functional and potentially testable with a dummy user.

@chadstewart chadstewart changed the title [Front-End] User Login Component [Front-End] Implement UI for User Login Component Jul 6, 2022
@bdougie
Copy link
Member

bdougie commented Jul 9, 2022

We have dropdowns in the UI for hot and the flagship app. They are necessary for the goal but shared since we will want to update those to whatever we do here. We historically hide things that don't need to be in the header nav, i.e. "open an issue on github" link.

app.opensauced.pizza

Image

hot.opensauced.pizza

Image

The dropdown includes the following, but keep in mind they were added to the list with no plan or thought.

  • version number
  • logout
  • link to open an issue
  • link to github profile (we shouldn't do this, we should eventually make the open sauced profile a thing).
  • link to docs

@pixelsbyeryc pixelsbyeryc added the needs design Front-end tasks that are missing a design. Create a new issue for the design. label Jul 9, 2022
@pixelsbyeryc
Copy link
Contributor

We can use some of the code from https://ariakit.org/examples/menu.

They already have the functionality + accessibility.

@pixelsbyeryc
Copy link
Contributor

@chadstewart @bdougie

I don't think I have the expertise to implement this... I don't know what the best way to create interactions with React, eg: click event to open a menu.

I'd love it if either of you could jump on a call with me and walk me through how you would implement this component. Not urgent.

@pixelsbyeryc pixelsbyeryc removed their assignment Jul 13, 2022
@bdougie
Copy link
Member

bdougie commented Jul 13, 2022

No worries and no need to try and deep dive on that. We can potentially punt on this since this experience for #59 will need to take this in consideration or vice versa.

Overall

  • Supabase auth will store the user in local storage using a JWT.
  • Dropdown can leverage headlessui or ariakit
  • This component can use a combo of the useSupabaseAuth hook and react state

But definitely let @chadstewart or myself pick this up.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants