Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make "we are more than... green squares" slogan accessible #249

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

CBID2
Copy link

@CBID2 CBID2 commented Apr 17, 2024

Description

This PR is a new of #164

Related Tickets & Documents

Closes #88

Mobile & Desktop Screenshots/Recordings

Note

There is no audio in the below video due to technical difficulties.

green.square.accessibility.test.mov

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

CBID2 and others added 19 commits September 17, 2023 17:05
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Co-authored-by: Lora Rusinouskaya <lrusinouka@gmail.com>
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 63bc22a
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/665ca21268cf4500083c3ad7
😎 Deploy Preview https://deploy-preview-249--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CBID2
Copy link
Author

CBID2 commented Jun 2, 2024

Hey @nickytonline or @bdougie, can this PR be merged?

@nickytonline
Copy link
Member

Hey @nickytonline or @bdougie, can this PR be merged?

I'm not really understanding the title of this PR and how this addresses the accessibility issue reported.

I also can't find the page this is located on in the site. I don't think it's in the production site anymore, at least from navigating around. What page(s) can I go to to test this?

@CBID2 CBID2 changed the title Creating custom css with svg fix: make "we are more than... green squares" slogan accessible Jun 4, 2024
@CBID2
Copy link
Author

CBID2 commented Jun 4, 2024

Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present.

@nickytonline
Copy link
Member

Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present.

Which page(s) in the deploy preview can I test this on? I can't seem to find it and there's no QA instructions.

@CBID2
Copy link
Author

CBID2 commented Jun 5, 2024

Hi @nickytonline. @bdougie encouraged me to do a new version of PR #164. It was sitting around for quite some time. This is why the square is no longer present.

Which page(s) in the deploy preview can I test this on? I can't seem to find it and there's no QA instructions.

It used to be on the teams page in the website, but I think it went away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Green squares is not accesible
2 participants