feat: Highlight Cards UI Generation (frontend-only) #36
Conversation
…auced.pizza into 35-feature-highlight-cards
Deadreyo
force-pushed
the
35-feature-highlight-cards
branch
from
ee469ec
to
09036b2
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Watched Files
This pull request modifies specific files that require careful review by the maintainers.
Files Matched
- package.json
There was a problem hiding this comment.
Very good work decoupling the cards, we should outsource the icons to the same design system as insights if we envision more than the heart emoji used and potentially experimenting with the alpha api for extended user information when doing the backend.
It can go to beta with just a small lint clean-up and improvement issues since this is just tackling the frontend side of things! 👍
…hub.com/open-sauced/opengraph.opensauced.pizza into 35-feature-highlight-cards
|
@0-vortex fixed the lint issues & merge conflicts |
|
It is not clear what "frontend-only" means in the title. Can you clarify that? Other than that, functionality of the card works. Also is there a test plan or steps to review or test the cards? |
Meaning that this PR is only responsible for only generating the cards, and not responsible for connecting to the backend or database.
There are scripts to manually generate and test the social cards visually , |
## [2.1.0-beta.3](v2.1.0-beta.2...v2.1.0-beta.3) (2023-05-02) ### 🍕 Features * Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847))
|
🎉 This PR is included in version 2.1.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: get highlight data function * feat: setup highlight testing * feat: data interfaces * refractor: split card codes * feat: highlight cards code structure * refractor: template shared folder * refractor: card footer component * refractor: separate o ut card style setup * feat: highlights UI complete * lint 138a847
## [2.1.0](v2.0.1...v2.1.0) (2023-05-09) ### 🐛 Bug Fixes * Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a)) ### 🍕 Features * adding utilities for cards local generation & testing ([#34](#34)) ([c5a5fec](c5a5fec)) * Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847)) * highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25)) * higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa)) * UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
closes #35
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?