This repository has been archived by the owner on Aug 13, 2024. It is now read-only.
feat: higlight card upload & storage #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
0-vortex
reviewed
May 3, 2023
0-vortex
suggested changes
May 3, 2023
There was a problem hiding this comment.
Cache change is required to get this to production, all other logic looks good to me! 👍
@brandonroberts can you also give this a look? Other than the effort required to switch this off of GitHub rate limits to our public API, this is good to go live IMHO
|
@0-vortex |
0-vortex
reviewed
May 3, 2023
0-vortex
approved these changes
May 4, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
## [2.1.0-beta.4](v2.1.0-beta.3...v2.1.0-beta.4) (2023-05-04) ### 🍕 Features * higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa))
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2023
* feat: higlight card upload & storage * feat: added parse int pipe * parseIntPipe * type fixes * feat: check if highlight needs regeneration * lint b6abefa
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2023
## [2.1.0](v2.0.1...v2.1.0) (2023-05-09) ### 🐛 Bug Fixes * Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a)) ### 🍕 Features * adding utilities for cards local generation & testing ([#34](#34)) ([c5a5fec](c5a5fec)) * Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847)) * highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25)) * higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa)) * UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Sets up the backend stage of highlight cards, i.e. uploading the generated image and returning it's link. Makes highlight cards ready for production.
Related Tickets & Documents
follow-up on #36
closes #40
Mobile & Desktop Screenshots/Recordings
https://opengraph-dev.sfo3.digitaloceanspaces.com/highlights/102.png
https://opengraph-dev.sfo3.digitaloceanspaces.com/highlights/103.png
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?