-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: highlights getting repo name & languages from pr's repo #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of very minor changes and it's good to go live IMHO π
Still some lint issues, what's the |
Itself and the things inside have |
## [2.1.0-beta.5](v2.1.0-beta.4...v2.1.0-beta.5) (2023-05-05) ### π Features * highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25))
π This PR is included in version 2.1.0-beta.5 π The release is available on: Your semantic-release bot π¦π |
* feat: github pr data insertion * requested changes * nit: remove unneeded typing * lint * type refractor * lint 1555a25
## [2.1.0](v2.0.1...v2.1.0) (2023-05-09) ### π Bug Fixes * Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a)) ### π Features * adding utilities for cards local generation & testing ([#34](#34)) ([c5a5fec](c5a5fec)) * Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847)) * highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25)) * higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa)) * UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
π This PR is included in version 2.1.0 π The release is available on: Your semantic-release bot π¦π |
What type of PR is this? (check all applicable)
Description
Before
User top repos and user top languages were displayed in highlight cards
After
Only the highlight PR's repo is displayed, and that repo's languages
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?