Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlights getting repo name & languages from pr's repo #41

Merged
merged 6 commits into from
May 5, 2023

Conversation

nightknighto
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Before

User top repos and user top languages were displayed in highlight cards

After

Only the highlight PR's repo is displayed, and that repo's languages

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@nightknighto nightknighto requested a review from 0-vortex May 4, 2023 18:59
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very minor changes and it's good to go live IMHO πŸš€

cc @brandonroberts

src/social-card/highlight-card/highlight-card.service.ts Outdated Show resolved Hide resolved
src/social-card/highlight-card/highlight-card.service.ts Outdated Show resolved Hide resolved
src/social-card/templates/shared/user-repos.ts Outdated Show resolved Hide resolved
@0-vortex
Copy link
Contributor

0-vortex commented May 4, 2023

Still some lint issues, what's the edges thing bothering you? Can help with that <3

@nightknighto
Copy link
Contributor Author

Still some lint issues, what's the edges thing bothering you? Can help with that <3

Itself and the things inside have | undefined type which just causes typescript to scream so have to check it everywhere

@nightknighto nightknighto merged commit 1555a25 into beta May 5, 2023
5 checks passed
@nightknighto nightknighto deleted the highlights-pr-data branch May 5, 2023 14:29
github-actions bot pushed a commit that referenced this pull request May 5, 2023
## [2.1.0-beta.5](v2.1.0-beta.4...v2.1.0-beta.5) (2023-05-05)

### πŸ• Features

* highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25))
@github-actions
Copy link

github-actions bot commented May 5, 2023

πŸŽ‰ This PR is included in version 2.1.0-beta.5 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request May 5, 2023
* feat: github pr data insertion

* requested changes

* nit: remove unneeded typing

* lint

* type refractor

* lint 1555a25
github-actions bot pushed a commit that referenced this pull request May 9, 2023
## [2.1.0](v2.0.1...v2.1.0) (2023-05-09)

### πŸ› Bug Fixes

* Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a))

### πŸ• Features

* adding utilities for cards local generation & testing ([#34](#34)) ([c5a5fec](c5a5fec))
* Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847))
* highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25))
* higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa))
* UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
@github-actions
Copy link

github-actions bot commented May 9, 2023

πŸŽ‰ This PR is included in version 2.1.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants