Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Overflowing language bar fix #38

Merged
merged 2 commits into from
Apr 30, 2023
Merged

fix: Overflowing language bar fix #38

merged 2 commits into from
Apr 30, 2023

Conversation

Deadreyo
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Fixes language bar overflowing out of its container

Related Tickets & Documents

fixes #23

Mobile & Desktop Screenshots/Recordings

Before

image

After

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Deadreyo Deadreyo requested a review from 0-vortex April 30, 2023 12:24
Copy link
Contributor

@0-vortex 0-vortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸ‘

@Deadreyo Deadreyo merged commit 3dc1a0a into beta Apr 30, 2023
5 checks passed
@Deadreyo Deadreyo deleted the overflow-langs-fix branch April 30, 2023 16:28
github-actions bot pushed a commit that referenced this pull request Apr 30, 2023
## [2.1.0-beta.2](v2.1.0-beta.1...v2.1.0-beta.2) (2023-04-30)

### πŸ› Bug Fixes

* Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a))
@github-actions
Copy link

πŸŽ‰ This PR is included in version 2.1.0-beta.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Apr 30, 2023
* test: add more cards

* fix: fix overflowing language bar 3dc1a0a
github-actions bot pushed a commit that referenced this pull request May 9, 2023
## [2.1.0](v2.0.1...v2.1.0) (2023-05-09)

### πŸ› Bug Fixes

* Overflowing language bar fix ([#38](#38)) ([3dc1a0a](3dc1a0a))

### πŸ• Features

* adding utilities for cards local generation & testing ([#34](#34)) ([c5a5fec](c5a5fec))
* Highlight Cards UI Generation (frontend-only) ([#36](#36)) ([138a847](138a847))
* highlights getting repo name & languages from pr's repo ([#41](#41)) ([1555a25](1555a25))
* higlight card upload & storage ([#39](#39)) ([b6abefa](b6abefa))
* UI adjustments ([#42](#42)) ([acbe81a](acbe81a))
@github-actions
Copy link

github-actions bot commented May 9, 2023

πŸŽ‰ This PR is included in version 2.1.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Languages bar overflow or is not padded on the right
2 participants