Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workflows #73

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Dec 19, 2023

Description

Sets the Node.js engine to a minimum of 18.17.0.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Relates to #72

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❀️! πŸŽ‰πŸ•
Say hello by joining the conversation in our Discord

@nickytonline nickytonline force-pushed the nickytonline/upgrade-to-node-18.19.0 branch from a820797 to 32bac91 Compare December 19, 2023 00:11
@nickytonline nickytonline changed the title chore: upgraded to Node.js 18.19.0 chore: upgraded to Node.js 18.17.0 Dec 19, 2023
@nickytonline
Copy link
Member Author

Maybe I'm reading the failure wrong, but doesn't moving to Node.js 18.17.0 fix the engine issue?

Run npm i -g npm@latest
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: npm@10.2.5
npm ERR! notsup Not compatible with your version of node/npm: npm@10.2.5
npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
npm ERR! notsup Actual:   {"npm":"8.19.[4](https://github.com/open-sauced/opengraph/actions/runs/7232618888/job/19765768242#step:4:5)","node":"v1[6](https://github.com/open-sauced/opengraph/actions/runs/7232618888/job/19765768242#step:4:7).20.2"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-12-19T00_11_4[7](https://github.com/open-sauced/opengraph/actions/runs/7232618888/job/19765768242#step:4:8)_407Z-debug-0.log
Error: Process completed with exit code 1.

@bdougie
Copy link
Member

bdougie commented Dec 19, 2023

Maybe I'm reading the failure wrong, but doesn't moving to Node.js 18.17.0 fix the engine issue?

I would think so, however it seems like something is quite seeing the npm and node change. Does npm run prebuild && npm run build work locally?

@brandonroberts
Copy link
Contributor

Maybe needs fixing here also https://github.com/open-sauced/opengraph/blob/beta/Dockerfile#L20

@nickytonline nickytonline changed the title chore: upgraded to Node.js 18.17.0 chore: upgraded to Node.js 20.10.0 Dec 19, 2023
@brandonroberts
Copy link
Contributor

brandonroberts commented Dec 19, 2023

The workflow files need to be updated to use the open-sauced/hot workflows instead of open-sauced/open-sauced also

https://github.com/open-sauced/app/blob/beta/.github/workflows/compliance.yml#L15
https://github.com/open-sauced/app/blob/beta/.github/workflows/development.yml#L14C1-L14C1

@nickytonline nickytonline force-pushed the nickytonline/upgrade-to-node-18.19.0 branch from d5184c3 to 90e62c7 Compare December 20, 2023 01:49
@bdougie
Copy link
Member

bdougie commented Dec 21, 2023

The workflow files need to be updated to use the open-sauced/hot workflows instead of open-sauced/open-sauced also

https://github.com/open-sauced/app/blob/beta/.github/workflows/compliance.yml#L15 https://github.com/open-sauced/app/blob/beta/.github/workflows/development.yml#L14C1-L14C1

This was helpful. I fix this PR with this - open-sauced/contributor.info@cd6bdc2

@nickytonline
Copy link
Member Author

Not sure why this fails still. All the workflows are updated, the docker file etc. 🫠

@brandonroberts
Copy link
Contributor

The workflows in opensauced/hot are set to use node 18, which would conflict with us trying to use node 20 here

@brandonroberts
Copy link
Contributor

@nickytonline
Copy link
Member Author

Il revert the node 20 upgrade then and just keep the updated workflows. Originally I thought it required Node 20, but it sounds like just updating workflows should be good.

@nickytonline nickytonline changed the title chore: upgraded to Node.js 20.10.0 chore: update workflows Dec 22, 2023
@nickytonline nickytonline merged commit c48f98d into beta Dec 22, 2023
7 checks passed
@nickytonline nickytonline deleted the nickytonline/upgrade-to-node-18.19.0 branch December 22, 2023 16:01
Copy link

πŸŽ‰ This PR is included in version 2.4.1-beta.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Copy link

πŸŽ‰ This PR is included in version 2.5.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants