BUG Don't add redundant href="#" to tabs

Fixes silverstripe/silverstripe-asset-admin#761
open-sausages · Apr 16, 2018 · 79e4f9c · 79e4f9c
1 parent f68fcf2
commit 79e4f9c
Show file tree

Hide file tree

Showing 5 changed files with 195 additions and 14 deletions.
diff --git a/client/dist/js/bundle.js b/client/dist/js/bundle.js
diff --git a/client/dist/styles/bundle.css b/client/dist/styles/bundle.css
diff --git a/client/src/components/Tabs/Tabs.js b/client/src/components/Tabs/Tabs.js
@@ -89,7 +89,6 @@ class Tabs extends Component {
           onClick={() => (this.toggle(child.props.name))}
           disabled={child.props.disabled}
           className={classNames}
-          href="#"
         >
           {child.props.title}
         </NavLink>

diff --git a/client/src/components/Tabs/Tabs.scss b/client/src/components/Tabs/Tabs.scss
@@ -16,6 +16,7 @@
     color: $text-muted;
     padding: $nav-link-padding;
     border-bottom-width: $nav-tabs-link-border-width;
+    cursor: pointer;
 
     &:hover,
     &:focus {