Add SilverStripeComponent base class #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| componentDidUpdate() { | ||
| this._emitCmsEvent('updateCmsHeading', { heading: this.state.headingName }); |
flashbackzoo
force-pushed
the
silverstripe-baseclass
branch
from
55085c2
to
51c255e
Compare
|
@chillu updated based on your feedback 😄 |
flashbackzoo
force-pushed
the
silverstripe-baseclass
branch
from
ab2cfd3
to
12745be
Compare
|
@chillu I've updated the docs with the Entwine override stuff and squashed the commits. Ready for review and (hopefully) merge. |
flashbackzoo
force-pushed
the
silverstripe-baseclass
branch
from
12745be
to
0a0bd65
Compare
scott1702
added a commit
that referenced
this pull request
Nov 5, 2015
Add SilverStripeComponent base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chillu this is the event based interfacing we talked about today. It's still a bit coupled in terms of both sides (React component and legacy script) need to know about the namespace and event names...
Thoughts?