Support flattened global translations #344
Conversation
There was a problem hiding this comment.
Tested this here - no errors and all text that comes from global translations looks to be present
|
Sorry, we've just realised we're having this again: Is this something to do with the new translation changes? |
|
Hmm, let me take a look. More soon. |
|
Possible fix - try also upgrading to jekyll-open-sdg-plugins 0.0.14 here: https://github.com/ONSdigital/sdg-indicators/blob/flattened-translations/Gemfile#L8 |
|
Upgraded but still having issue |
|
Actually it looks like this is happening on the staging site already, so I don't think it's related to this PR. Do you have any idea when that started? Or did it never get resolved? I remember we were looking into that recently. |
|
@LucyGwilliamAdmin Think I see the problem. The next Open SDG upgrade (0.9.0) will need to be simultaneous with an SDG Translations upgrade (0.8.0, already released). So try changing this line to version 0.8.0. |
|
So I have upgraded to 0.8.0 and that fixed the indicator title but now the goal title is gone from the ribbon on the goal page: |
|
@LucyGwilliamAdmin Sorry for the confusion - I meant to upgrade to sdg-translations 0.8.0 in your "flattened-translations" branch only - not in "develop". Any site using sdg-translations 0.8.0 will also need to be using open-sdg 0.9.0 (which we haven't released yet) and vice versa. Hmm, given this issue maybe we should go ahead and release 0.9.0 of open-sdg? |
|
@brockfanning sorry I thought you meant it would fix the issue on the staging/live site (which it did). I think that might be best. |
|
Should I finish the set chart axis feature first? |
|
@brockfanning the tab title is also missing e.g. If we don't want to do a new release just to fix UK site, I can downgrade sdg-translations to 0.7.0 - we will then be back with the issue of having duplicate indicator codes in the banner on indicator pages. No idea where that came from - as we haven't made any commits that would have messed with that. |
|
I think I know what's going on - for now you could try downgrading back to sdg-translations 0.7.0, but also make this change: in Gemfile, change |
|
This has fixed it - thanks! |
The sdg-translations project now has "flattened" global translation keys. For example, instead of this:
...now has this:
As a consequence several parts of the templates in Open SDG need to be adjusted. This is an attempt at that, as well as a general cleanup/deprecation of some indicator variables.