add more payload validation

open-solid · Nov 12, 2023 · 58c4d09 · 58c4d09
1 parent ddab470
commit 58c4d09
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 5 deletions.
diff --git a/tests/Functional/App/PostResourceAction/Controller/PostResourceBody.php b/tests/Functional/App/PostResourceAction/Controller/PostResourceBody.php
@@ -8,6 +8,6 @@
 #[Schema(writeOnly: true)]
 class PostResourceBody
 {
-    #[Property]
+    #[Property(minLength: 3)]
     public string $name;
 }
diff --git a/tests/Functional/App/PostResourceAction/Output/doc.json b/tests/Functional/App/PostResourceAction/Output/doc.json
@@ -48,7 +48,8 @@
                 ],
                 "properties": {
                     "name": {
-                        "type": "string"
+                        "type": "string",
+                        "minLength": 3
                     }
                 },
                 "type": "object",
@@ -197,4 +198,4 @@
             }
         }
     }
-}
+}
diff --git a/...sourceAction/Output/validation_error.json → ...ourceAction/Output/validation_error1.json b/...sourceAction/Output/validation_error.json → ...ourceAction/Output/validation_error1.json
diff --git a/tests/Functional/App/PostResourceAction/Output/validation_error2.json b/tests/Functional/App/PostResourceAction/Output/validation_error2.json
@@ -0,0 +1 @@
+{"type":"https:\/\/symfony.com\/errors\/validation","title":"Validation Failed","status":422,"detail":"name: This value is too short. It should have 3 characters or more.","violations":[{"propertyPath":"name","title":"This value is too short. It should have 3 characters or more.","template":"This value is too short. It should have {{ limit }} character or more.|This value is too short. It should have {{ limit }} characters or more.","parameters":{"{{ value }}":"\"fo\"","{{ limit }}":"3","{{ value_length }}":"2"},"type":"urn:uuid:9ff3fdc4-b214-49db-8718-39c315e33d45"}]}
diff --git a/tests/Functional/PostResourceActionTest.php b/tests/Functional/PostResourceActionTest.php
@@ -29,7 +29,7 @@ public function testEndpoint(): void
         $this->assertApiResponse($content);
     }
 
-    public function testValidation(): void
+    public function testValidation1(): void
     {
         $client = self::createClient();
         $client->jsonRequest('POST', '/resources', [
@@ -40,6 +40,20 @@ public function testValidation(): void
 
         self::assertResponseIsUnprocessable();
         $this->assertJson($content);
-        $this->assertApiResponse($content, filename: 'validation_error.json');
+        $this->assertApiResponse($content, filename: 'validation_error1.json');
+    }
+
+    public function testValidation2(): void
+    {
+        $client = self::createClient();
+        $client->jsonRequest('POST', '/resources', [
+            'name' => 'fo',
+        ]);
+
+        $content = $client->getResponse()->getContent();
+
+        self::assertResponseIsUnprocessable();
+        $this->assertJson($content);
+        $this->assertApiResponse($content, filename: 'validation_error2.json');
     }
 }