Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update charReader test case #1095

Merged
merged 3 commits into from Nov 15, 2019
Merged

update charReader test case #1095

merged 3 commits into from Nov 15, 2019

Conversation

dota17
Copy link
Member

@dota17 dota17 commented Nov 12, 2019

update charReader test case
Coverage of json_reader.cpp raises up to 89.52%

@coveralls
Copy link

coveralls commented Nov 12, 2019 •
edited

Coverage Status

Coverage increased (+1.3%) to 92.13% when pulling 7c87a90 on dota17:testcoverage into d2e6a97 on open-source-parsers:master.

BillyDonahue
BillyDonahue approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@BillyDonahue BillyDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with small requests

src/test_lib_json/main.cpp Outdated Show resolved Hide resolved
src/test_lib_json/main.cpp Outdated Show resolved Hide resolved
@dota17 dota17 force-pushed the testcoverage branch 2 times, most recently from 14af5b3 to 49bdade Compare November 12, 2019 08:51
@dota17 dota17 mentioned this pull request Nov 13, 2019
Open
@dota17 dota17 closed this Nov 14, 2019
@dota17 dota17 deleted the testcoverage branch November 14, 2019 03:22
@dota17 dota17 restored the testcoverage branch November 14, 2019 03:24
@dota17 dota17 reopened this Nov 14, 2019
BillyDonahue
BillyDonahue requested changes Nov 14, 2019
View reviewed changes
src/test_lib_json/main.cpp Outdated Show resolved Hide resolved
src/test_lib_json/main.cpp Show resolved Hide resolved
BillyDonahue
BillyDonahue reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@BillyDonahue BillyDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as-is, but if you can take on the minor suggestions that would be even better, I think.

@dota17 dota17 merged commit f200239 into open-source-parsers:master Nov 15, 2019
@dota17 dota17 deleted the testcoverage branch November 15, 2019 07:00
@dota17 dota17 mentioned this pull request Dec 6, 2019
Closed
This was referenced Dec 26, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyDonahue BillyDonahue BillyDonahue requested changes

@cdunn2001 cdunn2001 cdunn2001 approved these changes

@baylesj baylesj Awaiting requested review from baylesj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dota17 @coveralls @cdunn2001 @BillyDonahue