New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Raw Unicode in Testcase #1127

Merged

dota17 merged 2 commits into open-source-parsers:master from dota17:replaceRawUnicode

Dec 26, 2019

Member

dota17 commented Dec 26, 2019

1.From #1095 (comment), this PR will replace raw unicode.
2.Fix the wrong use of JSONTEST_ASSERT_EQUAL, the expected value is the first.

dota17 added 2 commits

December 26, 2019 15:29


          use unicode code point

ffb0ac0


          change values' order, because JSONTEST_ASSERT_EQUAL(expected, actual)

ae0872c

coveralls commented Dec 26, 2019

Coverage remained the same at 93.629% when pulling ae0872c on dota17:replaceRawUnicode into 7e5485a on open-source-parsers:master.

dota17 merged commit 8f7f35c into open-source-parsers:master

dota17 mentioned this pull request

take unicode out of string literals dota17/jsoncpp#76

Closed

dota17 deleted the replaceRawUnicode branch

December 26, 2019 08:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment