-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rlease Version 00.11.z #1160
Conversation
I rewrite and revert some code to make the library can be built in pre-C++11 env and C++11 env.
So the people using |
@dota17, this seems like a good idea, but it won't be called This branch will be something completely different. How about |
I am happy and appreciated that you think it is a good idea. |
We can't use a number higher than the actual mainline release, since that would indicate that this is the latest release. We can't bump only the minor version number because that would indicate backward-compatbility. The right thing to do is for people to upgrade, but we're trying to help people who are stuck on old systems, right? For those people, we can't be sticklers about aesthetically pleasing names. The main goal is to reduce our maintenance burden. The old code-base has never stopped being headache. This new branch you're creating is going to become a third branch that we are forced to maintain forever. That at least needs to be clear from its name. |
Anyway, it is ready for review. @cdunn2001 |
Currently, this branch had merged all new commits since 3beb37e from master. |
(We're discussing a good branch-name in private email....) |
I think we should squash and rebase this branch. It should have used
(That uses Do you see the problem? We cannot track the history by eye. I hope we're going to delete |
Sorry, I will clean and recreate the history of the new branch before merging. |
Down the road, cherry-pick is really helpful because it shows at-a-glance which features have been added. With a merge-commit, you have to wonder how much of the other branch was included. It's an underused feature of git. |
I clean the git history. Now the new branch 00.11.z is based on master and has two new commits for this merging. |
Refer to #1151 .
I tried to combine the two branches -
0.y.z
and1.y.z
, so people can build the library based on their env and we don't need to maintain or release two versions.