Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run retention calculation in parallel #91

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Run retention calculation in parallel #91

merged 2 commits into from
Sep 30, 2023

Conversation

dae
Copy link
Collaborator

@dae dae commented Sep 30, 2023

Roughtly 10x speed-up if you have enough cores on your CPU.

Roughtly 10x speed-up if you have enough cores on your CPU.
Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty fast! It only costs me 1.23s to pass the test. Good job!

@L-M-Sherlock L-M-Sherlock merged commit 5d67e1c into main Sep 30, 2023
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the speedup branch September 30, 2023 05:59
@dae
Copy link
Collaborator Author

dae commented Sep 30, 2023

Currently weight training only uses one core. If point 2 on #88 (comment) is implemented, we could potentially achieve similar performance improvements by using a separate core to calculate each of the values that we then average.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants