-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameters for individual decks don't work #41
Comments
Was |
Can you step over the line 31-38, then to check the scope? |
Huh, weird. I'll test it a bit more later, now that I've disabled button king add-on. |
Do you click |
Nope, still the same. |
So weird😭. |
Do you not have the same issue? |
I'm looking forward to your good news! |
Alright, so this does change something. Deck-specific parameters still don't work though, even now. OR maybe it just so happened that both global and deck-specific parameters produced the same result. Frankly, I don't know how sensitive intervals are to changes in parameters. Ok, after a bit of testing with different parameters, I think we were fighting a non-existent problem - I think both global parameters and deck-specific parameters just happened to produce (roughly) the same intervals for that card of mine. That also means that it's probably unnecessary to optimize each deck individually, global parameters are probably good enough, aside from some crazy hard or crazy easy decks. We need some kind of sensitivity analysis, like "If I change this parameter by 5%, how much will the interval change?", that sort of thing. Aaaaaaaaaaaand the culprit is...Incremental Reading v4.11.3 (unofficial clone). Add-ons that don't cause problems: Well, at least now you can add these to the list of addons that are compatible with FSRS (or, rather, to the "These seem to work at first glance and don't immediately make the new algorithm shit itself" list). And yes, The King of Buttonf Add-ons doesn't interfere with FSRS, it seems. |
I add the incompatible add-ons to the list at Compatibility. |
Describe the bug
You can specify parameters for each deck, but right now only global parameters affect scheduling.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Different sets of parameters should produce different intervals.
Environment
Additional context
Here's all of my code:
code.txt
The text was updated successfully, but these errors were encountered: