Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/outlier filter & flatter power forgetting curve & new pretrain #22

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented Dec 15, 2023

  • Apply outlier filter to other models
  • Update FSRS-rs

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Dec 15, 2023
@L-M-Sherlock L-M-Sherlock changed the title Feat/outlier filter & flatter power forgetting curve Feat/outlier filter & flatter power forgetting curve & new pretrain Dec 19, 2023
@Expertium
Copy link
Contributor

Expertium commented Dec 20, 2023

Just a reminder that this should be v4.5, a new entry. Don't just change v4.
To clarify, if only pretrain was changed, then I would agree that this should be called v4. But since one of the main formulas has been changed, this should be called v4.5.

@L-M-Sherlock
Copy link
Member Author

I know about that. Due to a mistake, I have to re-run all the models😭. And I need to compare v4 with v4.5 by using the same outlier filter, so I need to run the script twice.

@Expertium
Copy link
Contributor

Minor nitpick: it should be called "FSRS v4.5", not "FSRS-4.5". Since previous versions have the letter v, let's keep it consistent.

@L-M-Sherlock
Copy link
Member Author

Due to the semantic version rule, I have used v4.5 in fsrs-optimizer: https://github.com/open-spaced-repetition/fsrs-optimizer/releases/tag/v4.5.0. So it's ambiguous.

@L-M-Sherlock L-M-Sherlock force-pushed the Feat/outlier-filter branch 3 times, most recently from b0e010b to 70d89cc Compare December 22, 2023 08:26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20231222_120428
I don't think that's a good idea. I've mentioned before that mode is sensitive to clustering. If we don't remove users who have parameters that are very close to their defaults, there will be clusters and the mode will just return the defaults.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we check all parameters, the user will be removed even if only one parameter is equal to the default parameter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's better than using a mode which just returns the same default parameters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@L-M-Sherlock L-M-Sherlock force-pushed the Feat/outlier-filter branch 2 times, most recently from d3383ae to d0c385c Compare December 23, 2023 04:23
@L-M-Sherlock L-M-Sherlock marked this pull request as ready for review December 24, 2023 02:53
@L-M-Sherlock L-M-Sherlock merged commit eae0ba8 into main Dec 24, 2023
@L-M-Sherlock L-M-Sherlock deleted the Feat/outlier-filter branch December 24, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants