-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/outlier filter & flatter power forgetting curve & new pretrain #22
Conversation
L-M-Sherlock
commented
Dec 15, 2023
•
edited
Loading
edited
- Apply outlier filter to other models
- Update FSRS-rs
Just a reminder that this should be v4.5, a new entry. Don't just change v4. |
I know about that. Due to a mistake, I have to re-run all the models😭. And I need to compare v4 with v4.5 by using the same outlier filter, so I need to run the script twice. |
a876e23
to
504786d
Compare
Minor nitpick: it should be called "FSRS v4.5", not "FSRS-4.5". Since previous versions have the letter v, let's keep it consistent. |
Due to the semantic version rule, I have used v4.5 in fsrs-optimizer: https://github.com/open-spaced-repetition/fsrs-optimizer/releases/tag/v4.5.0. So it's ambiguous. |
b0e010b
to
70d89cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we check all parameters, the user will be removed even if only one parameter is equal to the default parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's better than using a mode which just returns the same default parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
d3383ae
to
d0c385c
Compare
d0c385c
to
b7181da
Compare