Adding new module hr_payslip_compute_sheet #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues : #6 |
1 similar comment
Current coverage is 80.66% (diff: 26.19%)@@ 8.0 #9 diff @@
==========================================
Files 7 8 +1
Lines 139 181 +42
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 135 146 +11
- Misses 4 35 +31
Partials 0 0
|
andhit-r
requested changes
Jan 12, 2017
| "name": "HR Payslip Compute Sheet", | ||
| "version": "8.0.1.0.0", | ||
| "summary": "Adds wizard to compute sheet", | ||
| "category": "Base", |
| "data": [ | ||
| "wizards/hr_compute_sheet_views.xml", | ||
| "views/hr_payslip_views.xml", | ||
| "data/ir_actions_server_data.xml" |
There was a problem hiding this comment.
@mikevhe18 ini dinamain ir_values_data.xml aja mike
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- Copyright <YEAR(S)> <AUTHOR(S)> | |||
| <openerp> | ||
| <data> | ||
|
|
||
| <record id="hr_compute_sheet_act_window" model="ir.actions.act_window"> |
There was a problem hiding this comment.
Kan udah ada hr_compute_sheet_action di wizardnya mike. Pake yg udah ada aja, ga usah dibuat 2x
| <button | ||
| name="%(hr_compute_sheet_action)d" | ||
| type="action" | ||
| string="Compute Sheet" |
There was a problem hiding this comment.
State nya samain dengan tombol aslinya mike
| self.ensure_one() | ||
| obj_hr_payslip = self.env['hr.payslip'] | ||
| context = self._context | ||
| record_id = context['active_ids'] |
| context = self._context | ||
| record_id = context['active_ids'] | ||
|
|
||
| for data in record_id: |
There was a problem hiding this comment.
for payslip in self.browse(active_ids)
| record_id = context['active_ids'] | ||
|
|
||
| for data in record_id: | ||
| payslip = obj_hr_payslip.browse(data) |
| payslip = obj_hr_payslip.browse(data) | ||
| if payslip.state == 'draft': | ||
| if self.reload_input: | ||
| contract_ids = payslip.get_contract( |
There was a problem hiding this comment.
Baris 34 sampai 51 dijadikan method sendiri
| } | ||
| payslip.write(vals) | ||
| if self.reload_workdays: | ||
| contract_ids = payslip.get_contract( |
There was a problem hiding this comment.
Baris 53 - 71 dijadikan method sendiri
mikevhe18
force-pushed
the
8.0-hr_payslip_compute_sheet
branch
from
f3a5aff
to
fd1d075
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.