Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][stock_picking_account_policy] Adding unittest #27

Open
wants to merge 3 commits into
base: 8.0
Choose a base branch
from

Conversation

mikevhe18
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 57.587% when pulling 857bde3 on mikevhe18:8.0-stock_picking_account_policy into 506dc7d on open-synergy:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 57.587% when pulling 857bde3 on mikevhe18:8.0-stock_picking_account_policy into 506dc7d on open-synergy:8.0.

@codecov-io
Copy link

codecov-io commented May 30, 2017

Codecov Report

Merging #27 into 8.0 will increase coverage by 3.19%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##              8.0     #27      +/-   ##
=========================================
+ Coverage   54.21%   57.4%   +3.19%     
=========================================
  Files          23      23              
  Lines         546     547       +1     
=========================================
+ Hits          296     314      +18     
+ Misses        250     233      -17
Impacted Files Coverage Δ
...ock_picking_account_policy/models/stock_picking.py 96.15% <92.3%> (+68.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506dc7d...331cca3. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 6, 2017

Coverage Status

Coverage increased (+3.5%) to 57.664% when pulling 1542464 on mikevhe18:8.0-stock_picking_account_policy into 506dc7d on open-synergy:8.0.

@mikevhe18
Copy link
Contributor Author

@andhit-r Would you kind review this module again ?

@coveralls
Copy link

coveralls commented Jun 8, 2017

Coverage Status

Coverage increased (+3.2%) to 57.404% when pulling 331cca3 on mikevhe18:8.0-stock_picking_account_policy into 506dc7d on open-synergy:8.0.

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lihat review di #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants