Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks that attributes are added into the registry #290

Closed
lmolkova opened this issue Mar 5, 2024 · 2 comments
Closed

Add checks that attributes are added into the registry #290

lmolkova opened this issue Mar 5, 2024 · 2 comments

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Mar 5, 2024

We want all attributes to be defined in the registry.
Today the only way to achieve is through a code review and it's easy to overlook.

Ideally we should have a check that prevents adding attributes inside semconv definition see open-telemetry/semantic-conventions#197 (comment) for the context
@lmolkova lmolkova mentioned this issue Mar 12, 2024
Open
@jsuereth
Copy link
Contributor

jsuereth commented May 9, 2024

We may be able to move this over to weaver: open-telemetry/semantic-conventions#1014

@lmolkova
Copy link
Contributor Author

Fixed in open-telemetry/semantic-conventions#1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Tooling
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsuereth @lmolkova