Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new entity to the YAML model for "stand alone" attributes #202

Closed
joaopgrassi opened this issue Sep 7, 2023 · 3 comments
Closed

Add new entity to the YAML model for "stand alone" attributes #202

joaopgrassi opened this issue Sep 7, 2023 · 3 comments
Labels
enhancement New feature or request semconv/md Related specifically to the markdown output of the semantic convention generator semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.

Comments

@joaopgrassi
Copy link
Member

joaopgrassi commented Sep 7, 2023

The semantic conventions SIG has agreed to go forward with the proposal open-telemetry/semantic-conventions#197 to decouple the attribute definition from its usage in the conventions. Essentially, we will achieve a "registry" of attributes that are standalone and then can be referenced by any convention.

During the initial split for HTTP open-telemetry/semantic-conventions#208 we saw that the current YAML model is not fit for this. The attributes entity today have many properties such as requirement level that are not relevant for the registry. For ex, the requirement level is rendered in markdown, which does not apply for the registry concept.

As a temporary workaround, @AlexanderWert worked on #190 to unblock working on the registry "move". But in the long run, we should have a better solution, that involves modifying our YAML model and introduce a new entity for such attribute registry type.

@AlexanderWert also worked on a proposal for this, which can be seen in #191

Once we have implemented the feature in YAML, we should consider removing the workaround done in #190.

@joaopgrassi joaopgrassi added enhancement New feature or request semconv Related to the semantic convention generator. semconv/md Related specifically to the markdown output of the semantic convention generator semconv/model Related to the data model or YAML format of the semantic convention generator labels Sep 7, 2023
@Oberon00
Copy link
Member

Oberon00 commented Sep 7, 2023

IMHO, attribute_group could (should?) be adapted to fulfill these instead of adding another type

@lmolkova
Copy link
Contributor

Related to #290

@jsuereth
Copy link
Contributor

jsuereth commented Oct 9, 2024

Closing as wontfix. We've migrated attribute registry to weaver with policy enforcement. I think there's an overall question of how we evolve our YAML model to better account for a registry and formalize things in group, e.g.

@jsuereth jsuereth closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semconv/md Related specifically to the markdown output of the semantic convention generator semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.
Projects
Archived in project
Development

No branches or pull requests

4 participants