Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Data Explorer Exporter time formatting #16546

Closed
tmeadon opened this issue Nov 30, 2022 · 10 comments
Closed

Azure Data Explorer Exporter time formatting #16546

tmeadon opened this issue Nov 30, 2022 · 10 comments
Labels
exporter/azuredataexplorer needs triage New item requiring triage

Comments

@tmeadon
Copy link

tmeadon commented Nov 30, 2022

Component(s)

exporter/azuredataexplorer

Describe the issue you're reporting

Due to the use of RFC3339 formatting in the ADX exporter, timestamps in spans, metrics, and logs do not include milliseconds or nanoseconds, despite this level of precision being present in the telemetry emitted by the SDK (.NET in my case). This makes it impossible to sort spans in a given trace when they all complete within the same second - they appear to all happen simultaneously.
@tmeadon tmeadon added the needs triage New item requiring triage label Nov 30, 2022
@tmeadon tmeadon mentioned this issue Nov 30, 2022
Closed
@tmeadon
Copy link
Author

tmeadon commented Nov 30, 2022

/label exporter/azuredataexplorer

@tmeadon
Copy link
Author

tmeadon commented Nov 30, 2022

Looks like the new issue workflow failed so pinging code owners manually. Hey @asaharan, @ag-ramachandran 👋

@ag-ramachandran
Copy link
Contributor

@tmeadon looking into this. Will replicate and provide a fix for this

ag-ramachandran referenced this issue in ag-ramachandran/opentelemetry-collector-contrib Dec 1, 2022
@ag-ramachandran
*Fixes issue #16546 adding support for timestamp in Nano second preci…
833999a 
…sion
@ag-ramachandran ag-ramachandran mentioned this issue Dec 1, 2022
Merged
@ag-ramachandran
Copy link
Contributor

@tmeadon Further update, internally testing the fix here . Will get this out by later today as a PR to the main repo
We also have some performance fixes & SDK fixes lined up for subsequent releases.

@tmeadon
Copy link
Author

tmeadon commented Dec 1, 2022

Awesome! Thanks @ag-ramachandran 👍

What needs to happen following a merge to the main repo before I can consume these changes?

@ag-ramachandran
Copy link
Contributor

Awesome! Thanks @ag-ramachandran 👍

What needs to happen following a merge to the main repo before I can consume these changes?

That is right, we will raise the PR to the main repo later today or worst case tomorrow. Once it gets into the main branch it should be good in the next build

ag-ramachandran referenced this issue in ag-ramachandran/opentelemetry-collector-contrib Dec 1, 2022
@ag-ramachandran @asaharn
*Fixes issue #16546 adding support for timestamp in Nano second preci…
967b14a 
…sion (#3583)

* *Fixes issue #16546 adding support for timestamp in Nano second precision
* * Add changelog, amend testcases
* * azure-kusto-go version update

Co-authored-by: Abhishek Saharn <asaharn@microsoft.com>
@ag-ramachandran ag-ramachandran mentioned this issue Dec 1, 2022
Merged
@ag-ramachandran
Copy link
Contributor

@tmeadon: Final update , #16568 raised for this issue

@tmeadon
Copy link
Author

tmeadon commented Dec 1, 2022

Thanks for looking at this so quickly @ag-ramachandran!

codeboten pushed a commit that referenced this issue Dec 1, 2022
@ag-ramachandran @asaharn
Fix nano timestamp precision: Issue #16546 (#16568)
089e5e7 
1. The current timestamp used in the collector is RFC3339, this causes truncation and makes it hard when much more granular precision of time is needed. This is changed to RFC3339Nano
2. Updates underlying SDK to interact with the database

Co-authored-by: Abhishek Saharn <asaharn@microsoft.com>
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this issue Dec 6, 2022
@ag-ramachandran @asaharn @shalper2
Fix nano timestamp precision: Issue open-telemetry#16546 (open-teleme…
ca49207 
…try#16568)

1. The current timestamp used in the collector is RFC3339, this causes truncation and makes it hard when much more granular precision of time is needed. This is changed to RFC3339Nano
2. Updates underlying SDK to interact with the database

Co-authored-by: Abhishek Saharn <asaharn@microsoft.com>
@ag-ramachandran
Copy link
Contributor

Hello @tmeadon, Since the PR is merged the latest build should have this fix on the distribution. Would you be able to give this a try and close the issue if the fix looks fine.

@tmeadon
Copy link
Author

tmeadon commented Dec 19, 2022

Perfect!

image

Thanks again @ag-ramachandran 😀

@tmeadon tmeadon closed this as completed Dec 19, 2022
@plantfansam plantfansam mentioned this issue Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/azuredataexplorer needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmeadon @ag-ramachandran