Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] build-examples build is broken #32138

Closed
atoulme opened this issue Apr 3, 2024 · 2 comments · Fixed by #32156
Closed

[CI] build-examples build is broken #32138

atoulme opened this issue Apr 3, 2024 · 2 comments · Fixed by #32156
Labels
ci-cd CI, CD, testing, build issues

Comments

@atoulme
Copy link
Contributor

atoulme commented Apr 3, 2024 •
edited

Component(s)

No response

Describe the issue you're reporting

See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8532718349/job/23374328167?pr=32137

docker-compose -f examples/demo/docker-compose.yaml build
/bin/bash: line 1: docker-compose: command not found
make: *** [Makefile:350: build-examples] Error 127
Error: Process completed with exit code 2.
@atoulme atoulme added the needs triage New item requiring triage label Apr 3, 2024
@crobert-1 crobert-1 added the ci-cd CI, CD, testing, build issues label Apr 3, 2024
@BinaryFissionGames
Copy link
Contributor

Looks like using docker compose instead of docker-compose may fix, according to this discussion?
https://github.com/orgs/community/discussions/116610

@crobert-1
Copy link
Member

Thanks for the reference @BinaryFissionGames, looks right to me. The active discussion shows that runners are being actively upgraded. From what I can tell, it looks like that should be all that's necessary according to the migration doc.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Apr 3, 2024
@crobert-1 crobert-1 mentioned this issue Apr 3, 2024
Merged
mx-psi pushed a commit that referenced this issue Apr 4, 2024
@crobert-1 @atoulme
[chore][CI/CD] Fix build-examples (#32156)
d2440a2 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
GitHub runners are being upgraded to docker v2. This requires `docker
compose` to be used instead of `docker-compose`. I'm not aware of any
other requirements for updating `build-examples` at this time.

**Link to tracking Issue:** <Issue number if applicable>
Resolves
#32138

**Testing:** <Describe what testing was performed and which tests were
added.>
Working locally, github runners won't run on updated code until merged
into main AFAIK, unfortunately.

Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
@github-actions github-actions bot mentioned this issue Apr 9, 2024
Open
ycombinator pushed a commit to ycombinator/opentelemetry-collector-contrib that referenced this issue Apr 9, 2024
@crobert-1 @atoulme @ycombinator
[chore][CI/CD] Fix build-examples (open-telemetry#32156)
31a503f 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
GitHub runners are being upgraded to docker v2. This requires `docker
compose` to be used instead of `docker-compose`. I'm not aware of any
other requirements for updating `build-examples` at this time.

**Link to tracking Issue:** <Issue number if applicable>
Resolves
open-telemetry#32138

**Testing:** <Describe what testing was performed and which tests were
added.>
Working locally, github runners won't run on updated code until merged
into main AFAIK, unfortunately.

Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
@crobert-1 @atoulme @rimitchell
[chore][CI/CD] Fix build-examples (open-telemetry#32156)
f259fed 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
GitHub runners are being upgraded to docker v2. This requires `docker
compose` to be used instead of `docker-compose`. I'm not aware of any
other requirements for updating `build-examples` at this time.

**Link to tracking Issue:** <Issue number if applicable>
Resolves
open-telemetry#32138

**Testing:** <Describe what testing was performed and which tests were
added.>
Working locally, github runners won't run on updated code until merged
into main AFAIK, unfortunately.

Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore][CI/CD] Fix build-examples crobert-1/opentelemetry-collector-contrib
3 participants
@atoulme @BinaryFissionGames @crobert-1