[chore][CI/CD] Fix build-examples #32156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Apr 3, 2024
atoulme
approved these changes
Apr 4, 2024
ycombinator
pushed a commit
to ycombinator/opentelemetry-collector-contrib
that referenced
this pull request
Apr 9, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> GitHub runners are being upgraded to docker v2. This requires `docker compose` to be used instead of `docker-compose`. I'm not aware of any other requirements for updating `build-examples` at this time. **Link to tracking Issue:** <Issue number if applicable> Resolves open-telemetry#32138 **Testing:** <Describe what testing was performed and which tests were added.> Working locally, github runners won't run on updated code until merged into main AFAIK, unfortunately. Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> GitHub runners are being upgraded to docker v2. This requires `docker compose` to be used instead of `docker-compose`. I'm not aware of any other requirements for updating `build-examples` at this time. **Link to tracking Issue:** <Issue number if applicable> Resolves open-telemetry#32138 **Testing:** <Describe what testing was performed and which tests were added.> Working locally, github runners won't run on updated code until merged into main AFAIK, unfortunately. Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
GitHub runners are being upgraded to docker v2. This requires
docker composeto be used instead ofdocker-compose. I'm not aware of any other requirements for updatingbuild-examplesat this time.Link to tracking Issue:
Resolves #32138
Testing:
Working locally, github runners won't run on updated code until merged into main AFAIK, unfortunately.