Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/vcenter] vcenter.cluster.memory.effective Has Incorrect Unit #32782

Closed
StefanKurek opened this issue Apr 30, 2024 · 2 comments
Closed

[receiver/vcenter] vcenter.cluster.memory.effective Has Incorrect Unit #32782

StefanKurek opened this issue Apr 30, 2024 · 2 comments
Labels
bug Something isn't working receiver/vcenter

Comments

@StefanKurek
Copy link
Contributor

Component(s)

receiver/vcenter

What happened?

Description

Currently, the metric vcenter.cluster.memory.effective appears to be reporting a value in MiB rather than bytes as the metadata of the receiver suggests. This is backed up by the documentation here.

Steps to Reproduce

Collect against any vCenter environment with an active Cluster.

Expected Result

The vcenter.cluster.memory.effective metric would be returned for Cluster resources with the value representing a number of bytes.

Actual Result

The vcenter.cluster.memory.effective metric is returned for Cluster resources with the value representing a number of MiB.

Collector version

v1.6.0/v0.99.0

Environment information

No response

OpenTelemetry Collector configuration

extensions:
  basicauth/prom:
    client_auth:
      username: [PROMUSER]
      password: [PROMPASS]

exporters:
  prometheusremotewrite:
    endpoint: [PROMENDPOINT]
    auth:
      authenticator: basicauth/prom
    resource_to_telemetry_conversion:
      enabled: true # Convert resource attributes to metric labels

processors:
  batch:
    # https://github.com/open-telemetry/opentelemetry-collector/tree/main/processor/batchprocessor

receivers:
  vcenter:
    endpoint: https://[VCENTERHOST]
    username: [VCENTERUSER]
    password: [VCENTERPASS]
    tls:
      insecure: true
    collection_interval: 1m
    initial_delay: 1s

service:
  extensions: [basicauth/prom]
  pipelines:
    metrics:
      receivers: [vcenter]
      processors: [batch]
      exporters: [prometheusremotewrite]

Log output

No response

Additional context

No response
@StefanKurek StefanKurek added bug Something isn't working needs triage New item requiring triage labels Apr 30, 2024
@StefanKurek
Copy link
Contributor Author

@djaglowski I propose just modifying the code to convert the recorded datapoint values for this metric from MiB to bytes.

@StefanKurek StefanKurek mentioned this issue Apr 30, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for receiver/vcenter: @djaglowski @schmikei @StefanKurek. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@JaredTan95 JaredTan95 removed the needs triage New item requiring triage label May 1, 2024
djaglowski pushed a commit that referenced this issue May 1, 2024
@StefanKurek
[receiver/vcenter] Updates vcenter.cluster.memory.effective metric (#…
bae7e6b 
…32783)

**Description:** <Describe what has changed.>
Currently the unit is incorrect for the reported metric value of
`vcenter.cluster.memory.effective`. This updates the values to actually
report in the unit of bytes (to match metadata).

This also updates the metadata description to be a little more accurate

**Link to tracking Issue:** <Issue number if applicable>
#32782 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
@StefanKurek @rimitchell
[receiver/vcenter] Updates vcenter.cluster.memory.effective metric (o…
62231c4 
…pen-telemetry#32783)

**Description:** <Describe what has changed.>
Currently the unit is incorrect for the reported metric value of
`vcenter.cluster.memory.effective`. This updates the values to actually
report in the unit of bytes (to match metadata).

This also updates the metadata description to be a little more accurate

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32782 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
jlg-io pushed a commit to jlg-io/opentelemetry-collector-contrib that referenced this issue May 14, 2024
@StefanKurek @jlg-io
[receiver/vcenter] Updates vcenter.cluster.memory.effective metric (o…
2cf9f52 
…pen-telemetry#32783)

**Description:** <Describe what has changed.>
Currently the unit is incorrect for the reported metric value of
`vcenter.cluster.memory.effective`. This updates the values to actually
report in the unit of bytes (to match metadata).

This also updates the metadata description to be a little more accurate

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32782 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working receiver/vcenter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StefanKurek @JaredTan95 @crobert-1