Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] Updates vcenter.cluster.memory.effective metric #32783

Conversation

StefanKurek
Copy link
Contributor

Description:
Currently the unit is incorrect for the reported metric value of vcenter.cluster.memory.effective. This updates the values to actually report in the unit of bytes (to match metadata).

This also updates the metadata description to be a little more accurate

Link to tracking Issue:
#32782

Testing:
Unit/integration tests updated and tested. Local environment tested.

Documentation:
New documentation generated based on the metadata.

…etric

Updates description to be a little more accurate
Updates the values to actually report in the unit of bytes (to match metadata)
@djaglowski djaglowski merged commit bae7e6b into open-telemetry:main May 1, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone May 1, 2024
@StefanKurek StefanKurek deleted the fix/vcenterreceiver-cluster-metric-unit branch May 1, 2024 20:52
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
…pen-telemetry#32783)

**Description:** <Describe what has changed.>
Currently the unit is incorrect for the reported metric value of
`vcenter.cluster.memory.effective`. This updates the values to actually
report in the unit of bytes (to match metadata).

This also updates the metadata description to be a little more accurate

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32782 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants