Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sumologicexporter]: validate maximum timeout #33151

Closed
sumo-drosiek opened this issue May 21, 2024 · 1 comment
Closed

[sumologicexporter]: validate maximum timeout #33151

sumo-drosiek opened this issue May 21, 2024 · 1 comment
Labels
enhancement New feature or request exporter/sumologic

Comments

@sumo-drosiek
Copy link
Member

Component(s)

exporter/sumologic

Is your feature request related to a problem? Please describe.

We claim that the maximum timeout value is 55s, but as far as I see we do not validate it

Describe the solution you'd like

We should add validation and unit tests for the timeout value

Describe alternatives you've considered

No response

Additional context

Outcome of the following: #33021 (comment)
@sumo-drosiek sumo-drosiek added enhancement New feature or request needs triage New item requiring triage labels May 21, 2024
@sumo-drosiek sumo-drosiek mentioned this issue May 21, 2024
Merged
@crobert-1 crobert-1 added exporter/sumologic and removed needs triage New item requiring triage labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/sumologic: @aboguszewski-sumo @kkujawa-sumo @mat-rumian @rnishtala-sumo @sumo-drosiek @swiatekm-sumo. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue May 28, 2024
Open
@chan-tim-sumo chan-tim-sumo mentioned this issue Jun 12, 2024
Merged
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@chan-tim-sumo @cparkins
[exporter/sumologicexporter]: Added timeout validation (open-telemetr…
4abbeb1 
…y#33522)

- Default timeout is 30 seconds with a max limit of 55. There're no
validation checks for when [timeout is more than 55
seconds](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/sumologicexporter/README.md?plain=1#L104).

**Link to tracking Issue:** 
Closes open-telemetry#33151

**Testing:** 
- Unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/sumologic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sumo-drosiek @crobert-1