[exporter/sumologicexporter]: Added timeout validation #33522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aboguszewski-sumo,
kasia-kujawa,
mat-rumian,
rnishtala-sumo,
sumo-drosiek and
swiatekm
|
I think the easy cla check is still failing because I didn't set global user email in git until the most recent commit 🤔 |
|
@chan-tim-sumo Please squash commits, maybe it will help with the CLA bot |
swiatekm
approved these changes
Jun 13, 2024
chan-tim-sumo
force-pushed
the
chan-tim_timeoutValidation
branch
from
65d1f10
to
6de559d
Compare
|
oh i think i know why, even though after rebasing to one commit, the first commit's email is: after amending the author to sumo email: |
chan-tim-sumo
force-pushed
the
chan-tim_timeoutValidation
branch
from
6de559d
to
f793d0c
Compare
|
can anyone from @open-telemetry/collector-contrib-approvers take a look at this? 😄 |
crobert-1
reviewed
Jun 17, 2024
crobert-1
approved these changes
Jun 17, 2024
|
If a code owner can check to ensure the new minimum timeout limit looks good, I can add |
crobert-1
added
the
ready to merge
sumo-drosiek
approved these changes
Jun 18, 2024
|
@dmitryax can you take a look at this? ready to merge :D |
codeboten
approved these changes
Jun 19, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…y#33522) - Default timeout is 30 seconds with a max limit of 55. There're no validation checks for when [timeout is more than 55 seconds](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/sumologicexporter/README.md?plain=1#L104). **Link to tracking Issue:** Closes open-telemetry#33151 **Testing:** - Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation: